feat: add user setting for which default post type to use (#3491)

Author: omBratteng

__tests__/__snapshots__/settings.ts.snap

@@ -10,6 +10,7 @@ Object {
     "enableCardAnimations": true,
     "flags": Object {
       "clickbaitShieldEnabled": null,
+      "defaultWriteTab": null,
       "sidebarBookmarksExpanded": null,
       "sidebarCustomFeedsExpanded": null,
       "sidebarOtherExpanded": null,
@@ -44,6 +45,7 @@ Object {
     "enableCardAnimations": true,
     "flags": Object {
       "clickbaitShieldEnabled": null,
+      "defaultWriteTab": null,
       "sidebarBookmarksExpanded": null,
       "sidebarCustomFeedsExpanded": null,
       "sidebarOtherExpanded": null,
@@ -80,6 +82,7 @@ Object {
     "enableCardAnimations": true,
     "flags": Object {
       "clickbaitShieldEnabled": null,
+      "defaultWriteTab": null,
       "sidebarBookmarksExpanded": null,
       "sidebarCustomFeedsExpanded": null,
       "sidebarOtherExpanded": null,
@@ -116,6 +119,7 @@ Object {
     "enableCardAnimations": true,
     "flags": Object {
       "clickbaitShieldEnabled": null,
+      "defaultWriteTab": null,
       "sidebarBookmarksExpanded": null,
       "sidebarCustomFeedsExpanded": null,
       "sidebarOtherExpanded": null,

__tests__/settings.ts

@@ -119,6 +119,7 @@ describe('mutation updateUserSettings', () => {
       sidebarSquadExpanded
       sidebarBookmarksExpanded
       clickbaitShieldEnabled
+      defaultWriteTab
     }
   }
 }`;
@@ -154,6 +155,7 @@ describe('mutation updateUserSettings', () => {
       sidebarSquadExpanded: null,
       sidebarBookmarksExpanded: null,
       clickbaitShieldEnabled: null,
+      defaultWriteTab: null,
     });
   });
 
@@ -172,6 +174,7 @@ describe('mutation updateUserSettings', () => {
       sidebarSquadExpanded: null,
       sidebarBookmarksExpanded: null,
       clickbaitShieldEnabled: null,
+      defaultWriteTab: null,
     });
 
     const userSettings = await con.getRepository(Settings).findOneOrFail({
@@ -307,6 +310,7 @@ describe('mutation updateUserSettings', () => {
       sidebarSquadExpanded: null,
       sidebarBookmarksExpanded: null,
       clickbaitShieldEnabled: null,
+      defaultWriteTab: null,
     });
   });
 
@@ -341,6 +345,7 @@ describe('mutation updateUserSettings', () => {
       sidebarSquadExpanded: null,
       sidebarBookmarksExpanded: null,
       clickbaitShieldEnabled: null,
+      defaultWriteTab: null,
     });
   });
 

src/entity/Settings.ts

@@ -20,6 +20,12 @@ export enum ChecklistViewState {
   Hidden = 'hidden',
 }
 
+export enum DefaultWriteTab {
+  Share = 'Share',
+  NewPost = 'NewPost',
+  Poll = 'Poll',
+}
+
 export type SettingsFlags = Partial<{
   sidebarSquadExpanded: boolean;
   sidebarCustomFeedsExpanded: boolean;
@@ -30,6 +36,7 @@ export type SettingsFlags = Partial<{
   prompt: object;
   timezoneMismatchIgnore: string;
   lastPrompt: string;
+  defaultWriteTab: DefaultWriteTab;
 }>;
 
 export type SettingsFlagsPublic = Pick<
@@ -43,6 +50,7 @@ export type SettingsFlagsPublic = Pick<
   | 'prompt'
   | 'timezoneMismatchIgnore'
   | 'lastPrompt'
+  | 'defaultWriteTab'
 >;
 
 @Entity()
@@ -143,5 +151,6 @@ export const SETTINGS_DEFAULT = {
     sidebarResourcesExpanded: true,
     sidebarBookmarksExpanded: true,
     clickbaitShieldEnabled: true,
+    defaultWriteTab: DefaultWriteTab.NewPost,
   },
 };

src/schema/settings.ts

@@ -4,6 +4,7 @@ import { AuthContext, BaseContext } from '../Context';
 import {
   CampaignCtaPlacement,
   ChecklistViewState,
+  DefaultWriteTab,
   Settings,
   SETTINGS_DEFAULT,
   SettingsFlagsPublic,
@@ -52,10 +53,12 @@ interface GQLUpdateSettingsInput extends Partial<GQLSettings> {
   campaignCtaPlacement?: CampaignCtaPlacement;
   customLinks?: string[];
   optOutReadingStreak?: boolean;
+  defaultWriteTab?: DefaultWriteTab;
 }
 
 export const typeDefs = /* GraphQL */ `
   ${toGQLEnum(ChecklistViewState, 'ChecklistViewState')}
+  ${toGQLEnum(DefaultWriteTab, 'DefaultWriteTab')}
 
   type SettingsFlagsPublic {
     sidebarSquadExpanded: Boolean
@@ -66,6 +69,7 @@ export const typeDefs = /* GraphQL */ `
     clickbaitShieldEnabled: Boolean
     timezoneMismatchIgnore: String
     lastPrompt: String
+    defaultWriteTab: DefaultWriteTab
   }
 
   input SettingsFlagsPublicInput {
@@ -78,6 +82,7 @@ export const typeDefs = /* GraphQL */ `
     prompt: JSONObject
     timezoneMismatchIgnore: String
     lastPrompt: String
+    defaultWriteTab: DefaultWriteTab
   }
 
   """
@@ -367,6 +372,13 @@ export const resolvers: IResolvers<unknown, BaseContext> = traceResolvers<
         throw new ValidationError(`Invalid value for 'campaignCtaPlacement'`);
       }
 
+      if (
+        data?.flags?.defaultWriteTab &&
+        !Object.values(DefaultWriteTab).includes(data.flags.defaultWriteTab)
+      ) {
+        throw new ValidationError(`Invalid value for 'defaultWriteTab'`);
+      }
+
       const promptSchema = z.record(z.string(), z.boolean());
       const result = promptSchema.safeParse(data.flags?.prompt);