From 7814eadf153144e8593308fbb11f8ab7846a68eb Mon Sep 17 00:00:00 2001 From: Snider Date: Fri, 1 May 2026 00:28:36 +0100 Subject: [PATCH] fix(go): defer must be function call + drop unused testing import MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hotfix for build failures introduced in v0.16.0: - jobrunner/journal.go:134: defer f.Close → defer f.Close() - collect/bitcointalk.go:236: defer resp.Body.Close → defer resp.Body.Close() - plugin/config_test.go: drop unused `import "testing"` (file has no test bodies) audit.sh verdict still COMPLIANT. Build/vet/test all clean now. Refs tasks.lthn.sh/view.php?id=1248 --- go/collect/bitcointalk.go | 2 +- go/jobrunner/journal.go | 2 +- go/plugin/config_test.go | 2 -- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/go/collect/bitcointalk.go b/go/collect/bitcointalk.go index 0a891a9..51683d7 100644 --- a/go/collect/bitcointalk.go +++ b/go/collect/bitcointalk.go @@ -233,7 +233,7 @@ func fetchBitcoinTalkPage(ctx context.Context, url string) (string, error) /* v if err != nil { return "", err } - defer resp.Body.Close + defer resp.Body.Close() if resp.StatusCode >= 400 { return "", core.E("collect.BitcoinTalkCollector", core.Sprintf("http %s", resp.Status), nil) } diff --git a/go/jobrunner/journal.go b/go/jobrunner/journal.go index 0100852..fb42888 100644 --- a/go/jobrunner/journal.go +++ b/go/jobrunner/journal.go @@ -131,7 +131,7 @@ func (j *Journal) Append(signal *PipelineSignal, result *ActionResult) error /* if !ok { return core.E(sonarJournalJobrunnerJournalAppend, "open journal returned invalid writer", nil) } - defer f.Close + defer f.Close() if _, err := f.Write(append(payload, '\n')); err != nil { return core.E(sonarJournalJobrunnerJournalAppend, "write journal", err) diff --git a/go/plugin/config_test.go b/go/plugin/config_test.go index b60d450..dc87420 100644 --- a/go/plugin/config_test.go +++ b/go/plugin/config_test.go @@ -1,5 +1,3 @@ // SPDX-License-Identifier: EUPL-1.2 package plugin - -import "testing"