Review Class Structures in TFA Basic and update to D8 concepts

[doylejd]

There are several concepts in D8 that are not being utilized in the tfa_basic module.

• Dependency injection. Classes shouldn't need to use \Drupal:: in most cases.
• TBD

[therealssj]

We need to tackle this.
The login architecture is broken right now and when you try to login it gives you a fatal error.
The issue is here in the TFATotp plugin
public function __construct(array $context, array $configuration, $plugin_id, $plugin_definition) {

The plugin is initiated by the ContainerFactory class wherein the definition of plugin construct is
$plugin_class($configuration, $plugin_id, $plugin_definition)

If we remove the $context from TFATotp then how do we access the current user id as that is what the $context contains

[nerdstein]

This can likely be pulled from the main services container, e.g.:

$user = \Drupal::currentUser();

But, please don't lose sight of the dependency injection noted above. That's an important piece here as well to do a proper implementation

[therealssj]

I am not sure how you would accomplish getting the user through any other means
We are limited by the function call $plugin_class($configuration, $plugin_id, $plugin_definition)

[nerdstein]

$context can be removed and replaced with $user = \Drupal::currentUser();

Let's start there to see if this removes the fatal error. We'll work on applying best practices with dependency injection thereafter (for which we can likely bring in the current user).