feat: Enable 8 additional linters and fix type assertions

New linters enabled:
- asciicheck, bidichk (security)
- errcheck, errname, forcetypeassert, ineffassign (bug finders)
- staticcheck, unused (code quality)

Fixed 9 unchecked type assertions in confirm.go by adding
proper ok checks with error returns.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: cv

.golangci.yml

@@ -3,15 +3,23 @@ version: "2"
 linters:
   enable:
     # Bug finders
+    - asciicheck         # Non-ASCII identifiers
+    - bidichk            # Dangerous unicode sequences
     - bodyclose          # HTTP response body closure
     - durationcheck      # Duration multiplication bugs
     - embeddedstructfieldcheck # Embedded struct field access issues
+    - errcheck           # Unchecked errors
     - errorlint          # Error wrapping issues
     - errchkjson         # JSON encoding error checks
+    - errname            # Error naming conventions
     - fatcontext         # Context misuse in loops
+    - forcetypeassert    # Unchecked type assertions
+    - ineffassign        # Ineffective assignments
     - nilerr             # Returns nil even when error set
     - noctx              # Missing context.Context usage
     - nosprintfhostport  # URL construction bugs
+    - staticcheck        # Comprehensive static analysis
+    - unused             # Unused code
 
     # Security
     - gosec              # Security issues
@@ -70,10 +78,11 @@ linters:
         linters:
           - gocritic
         text: appendAssign
-      # Test files can have repeated strings
+      # Test files can have repeated strings and controlled type assertions
       - path: _test\.go
         linters:
           - goconst
+          - forcetypeassert
       # Global variables - justified exclusions:
       # 1. Read-only lookup tables (RegionConfigs, screenSizes, androidVersionToSDK)
       - path: internal/api/auth\.go

internal/cli/confirm.go

@@ -173,7 +173,11 @@ func waitForDoorsLocked(
 	pollInterval time.Duration,
 ) confirmationResult {
 	conditionChecker := func(status any) (bool, error) {
-		vStatus := status.(*api.VehicleStatusResponse)
+		vStatus, ok := status.(*api.VehicleStatusResponse)
+		if !ok {
+			return false, fmt.Errorf("unexpected status type: %T", status)
+		}
+
 		doorStatus, err := vStatus.GetDoorsInfo()
 		if err != nil {
 			return false, err
@@ -195,7 +199,11 @@ func waitForDoorsUnlocked(
 	pollInterval time.Duration,
 ) confirmationResult {
 	conditionChecker := func(status any) (bool, error) {
-		vStatus := status.(*api.VehicleStatusResponse)
+		vStatus, ok := status.(*api.VehicleStatusResponse)
+		if !ok {
+			return false, fmt.Errorf("unexpected status type: %T", status)
+		}
+
 		doorStatus, err := vStatus.GetDoorsInfo()
 		if err != nil {
 			return false, err
@@ -217,7 +225,11 @@ func waitForEngineRunning(
 	pollInterval time.Duration,
 ) confirmationResult {
 	conditionChecker := func(status any) (bool, error) {
-		evStatus := status.(*api.EVVehicleStatusResponse)
+		evStatus, ok := status.(*api.EVVehicleStatusResponse)
+		if !ok {
+			return false, fmt.Errorf("unexpected status type: %T", status)
+		}
+
 		hvacInfo, err := evStatus.GetHvacInfo()
 		if err != nil {
 			return false, err
@@ -239,7 +251,11 @@ func waitForEngineStopped(
 	pollInterval time.Duration,
 ) confirmationResult {
 	conditionChecker := func(status any) (bool, error) {
-		evStatus := status.(*api.EVVehicleStatusResponse)
+		evStatus, ok := status.(*api.EVVehicleStatusResponse)
+		if !ok {
+			return false, fmt.Errorf("unexpected status type: %T", status)
+		}
+
 		hvacInfo, err := evStatus.GetHvacInfo()
 		if err != nil {
 			return false, err
@@ -261,7 +277,11 @@ func waitForCharging(
 	pollInterval time.Duration,
 ) confirmationResult {
 	conditionChecker := func(status any) (bool, error) {
-		evStatus := status.(*api.EVVehicleStatusResponse)
+		evStatus, ok := status.(*api.EVVehicleStatusResponse)
+		if !ok {
+			return false, fmt.Errorf("unexpected status type: %T", status)
+		}
+
 		batteryInfo, err := evStatus.GetBatteryInfo()
 		if err != nil {
 			return false, err
@@ -283,7 +303,11 @@ func waitForNotCharging(
 	pollInterval time.Duration,
 ) confirmationResult {
 	conditionChecker := func(status any) (bool, error) {
-		evStatus := status.(*api.EVVehicleStatusResponse)
+		evStatus, ok := status.(*api.EVVehicleStatusResponse)
+		if !ok {
+			return false, fmt.Errorf("unexpected status type: %T", status)
+		}
+
 		batteryInfo, err := evStatus.GetBatteryInfo()
 		if err != nil {
 			return false, err
@@ -309,7 +333,11 @@ func waitForHvacOn(
 	pollInterval time.Duration,
 ) confirmationResult {
 	conditionChecker := func(status any) (bool, error) {
-		evStatus := status.(*api.EVVehicleStatusResponse)
+		evStatus, ok := status.(*api.EVVehicleStatusResponse)
+		if !ok {
+			return false, fmt.Errorf("unexpected status type: %T", status)
+		}
+
 		hvacInfo, err := evStatus.GetHvacInfo()
 		if err != nil {
 			return false, err
@@ -331,7 +359,11 @@ func waitForHvacOff(
 	pollInterval time.Duration,
 ) confirmationResult {
 	conditionChecker := func(status any) (bool, error) {
-		evStatus := status.(*api.EVVehicleStatusResponse)
+		evStatus, ok := status.(*api.EVVehicleStatusResponse)
+		if !ok {
+			return false, fmt.Errorf("unexpected status type: %T", status)
+		}
+
 		hvacInfo, err := evStatus.GetHvacInfo()
 		if err != nil {
 			return false, err
@@ -356,18 +388,22 @@ func waitForHvacSettings(
 	pollInterval time.Duration,
 ) confirmationResult {
 	conditionChecker := func(status any) (bool, error) {
-		evStatus := status.(*api.EVVehicleStatusResponse)
+		evStatus, ok := status.(*api.EVVehicleStatusResponse)
+		if !ok {
+			return false, fmt.Errorf("unexpected status type: %T", status)
+		}
+
 		hvacInfo, err := evStatus.GetHvacInfo()
 		if err != nil {
 			return false, err
 		}
 
-		// Check temperature with tolerance of 0.5C
+		// Check temperature with tolerance of 0.5C.
 		const tempTolerance = 0.5
 		tempMatch := hvacInfo.TargetTempC >= targetTemp-tempTolerance &&
 			hvacInfo.TargetTempC <= targetTemp+tempTolerance
 
-		// Check defroster settings
+		// Check defroster settings.
 		defrostersMatch := hvacInfo.FrontDefroster == frontDefroster &&
 			hvacInfo.RearDefroster == rearDefroster