Remove unnecessary public qualifiers

The EscapingXmlStreamWriter and XmlReportData are package private. So
their methods do not need to be public. This makes it easier to see
which parts of the API are intended to be used outside this library.

Author: mpkorstanje

java/src/main/java/io/cucumber/junitxmlformatter/EscapingXmlStreamWriter.java

@@ -11,7 +11,7 @@ class EscapingXmlStreamWriter implements AutoCloseable {
 
     private final XMLStreamWriter writer;
 
-    public EscapingXmlStreamWriter(XMLStreamWriter writer) {
+    EscapingXmlStreamWriter(XMLStreamWriter writer) {
         this.writer = Objects.requireNonNull(writer);
     }
 
@@ -20,41 +20,41 @@ public void close() throws XMLStreamException {
         writer.close();
     }
 
-    public void writeStartDocument(String encoding, String version) throws XMLStreamException {
+    void writeStartDocument(String encoding, String version) throws XMLStreamException {
         writer.writeStartDocument(encoding, version);
     }
 
-    public void newLine() throws XMLStreamException {
+    void writeNewLine() throws XMLStreamException {
         writer.writeCharacters("\n");
     }
 
-    public void writeStartElement(String localName) throws XMLStreamException {
+    void writeStartElement(String localName) throws XMLStreamException {
         writer.writeStartElement(localName);
     }
 
-    public void writeEndElement() throws XMLStreamException {
+    void writeEndElement() throws XMLStreamException {
         writer.writeEndElement();
     }
 
-    public void writeEndDocument() throws XMLStreamException {
+    void writeEndDocument() throws XMLStreamException {
         writer.writeEndDocument();
     }
 
-    public void flush() throws XMLStreamException {
+    void flush() throws XMLStreamException {
         writer.flush();
     }
 
-    public void writeEmptyElement(String localName) throws XMLStreamException {
+    void writeEmptyElement(String localName) throws XMLStreamException {
         writer.writeEmptyElement(localName);
     }
 
-    public void writeAttribute(String localName, String value) throws XMLStreamException {
+    void writeAttribute(String localName, String value) throws XMLStreamException {
         writer.writeAttribute(localName, escapeIllegalChars(value));
     }
 
     private static final Pattern CDATA_TERMINATOR_SPLIT = Pattern.compile("(?<=]])(?=>)");
 
-    public void writeCData(String data) throws XMLStreamException {
+    void writeCData(String data) throws XMLStreamException {
         // https://stackoverflow.com/questions/223652/is-there-a-way-to-escape-a-cdata-end-token-in-xml
         for (String part : CDATA_TERMINATOR_SPLIT.split(data)) {
             // see https://www.w3.org/TR/xml/#dt-cdsection

java/src/main/java/io/cucumber/junitxmlformatter/XmlReportData.java

@@ -35,7 +35,7 @@ class XmlReportData {
 
     private static final long MILLIS_PER_SECOND = SECONDS.toMillis(1L);
 
-    public XmlReportData(NamingStrategy namingStrategy) {
+    XmlReportData(NamingStrategy namingStrategy) {
         this.namingStrategy = namingStrategy;
     }
 
@@ -77,7 +77,7 @@ String getPickleName(TestCaseStarted testCaseStarted) {
         return query.findNameOf(pickle, namingStrategy);
     }
 
-    public String getFeatureName(TestCaseStarted testCaseStarted) {
+    String getFeatureName(TestCaseStarted testCaseStarted) {
         return query.findFeatureBy(testCaseStarted)
                 .map(Feature::getName)
                 .orElseThrow(() -> new IllegalStateException("No feature for " + testCaseStarted));

java/src/main/java/io/cucumber/junitxmlformatter/XmlReportWriter.java

@@ -30,7 +30,7 @@ void writeXmlReport(Writer out) throws XMLStreamException {
         XMLOutputFactory factory = XMLOutputFactory.newInstance();
         EscapingXmlStreamWriter writer = new EscapingXmlStreamWriter(factory.createXMLStreamWriter(out));
         writer.writeStartDocument("UTF-8", "1.0");
-        writer.newLine();
+        writer.writeNewLine();
         writeTestsuite(writer);
         writer.writeEndDocument();
         writer.flush();
@@ -39,14 +39,14 @@ void writeXmlReport(Writer out) throws XMLStreamException {
     private void writeTestsuite(EscapingXmlStreamWriter writer) throws XMLStreamException {
         writer.writeStartElement("testsuite");
         writeSuiteAttributes(writer);
-        writer.newLine();
+        writer.writeNewLine();
 
         for (TestCaseStarted testCaseStarted : data.getAllTestCaseStarted()) {
             writeTestcase(writer, testCaseStarted);
         }
 
         writer.writeEndElement();
-        writer.newLine();
+        writer.writeNewLine();
     }
 
     private void writeSuiteAttributes(EscapingXmlStreamWriter writer) throws XMLStreamException {
@@ -75,11 +75,11 @@ private static EnumSet<TestStepResultStatus> createNotPassedNotSkippedSet() {
     private void writeTestcase(EscapingXmlStreamWriter writer, TestCaseStarted testCaseStarted) throws XMLStreamException {
         writer.writeStartElement("testcase");
         writeTestCaseAttributes(writer, testCaseStarted);
-        writer.newLine();
+        writer.writeNewLine();
         writeNonPassedElement(writer, testCaseStarted);
         writeStepAndResultList(writer, testCaseStarted);
         writer.writeEndElement();
-        writer.newLine();
+        writer.writeNewLine();
     }
 
     private void writeTestCaseAttributes(EscapingXmlStreamWriter writer, TestCaseStarted testCaseStarted) throws XMLStreamException {
@@ -117,22 +117,22 @@ private void writeNonPassedElement(EscapingXmlStreamWriter writer, TestCaseStart
         }
         if (hasMessageOrStackTrace) {
             if (exceptionStackTrace.isPresent()) {
-                writer.newLine();
+                writer.writeNewLine();
                 writer.writeCData(exceptionStackTrace.get());
-                writer.newLine();
+                writer.writeNewLine();
             } else {
                 // Fall back to message for older implementations
                 // that put the stack trace in the message
-                writer.newLine();
+                writer.writeNewLine();
                 writer.writeCData(message.get());
-                writer.newLine();
+                writer.writeNewLine();
             }
         }
 
         if (hasMessageOrStackTrace) {
             writer.writeEndElement();
         }
-        writer.newLine();
+        writer.writeNewLine();
     }
 
     private void writeStepAndResultList(EscapingXmlStreamWriter writer, TestCaseStarted testCaseStarted) throws XMLStreamException {
@@ -143,7 +143,7 @@ private void writeStepAndResultList(EscapingXmlStreamWriter writer, TestCaseStar
         writer.writeStartElement("system-out");
         writer.writeCData(createStepResultList(results));
         writer.writeEndElement();
-        writer.newLine();
+        writer.writeNewLine();
     }
 
     private static String createStepResultList(List<Map.Entry<String, String>> results) {