Commit fd56bac
committed
wifi: nl80211: call kfree without a NULL check
JIRA: https://issues.redhat.com/browse/RHEL-114889
commit 249e144
Author: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Date: Mon Oct 20 10:57:45 2025 +0300
wifi: nl80211: call kfree without a NULL check
Coverity is unhappy because we may leak old_radio_rts_threshold. Since
this pointer is only valid in the context of the function and kfree is
NULL pointer safe, don't check and just call kfree.
Note that somehow, we were checking old_rts_threshold to free
old_radio_rts_threshold which is a bit odd.
Fixes: 2646379 ("wifi: cfg80211: Add Support to Set RTS Threshold for each Radio")
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Link: https://patch.msgid.link/20251020075745.44168-1-emmanuel.grumbach@intel.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>1 parent e97a4b0 commit fd56bac
1 file changed
+1
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4017 | 4017 | | |
4018 | 4018 | | |
4019 | 4019 | | |
4020 | | - | |
4021 | | - | |
| 4020 | + | |
4022 | 4021 | | |
4023 | 4022 | | |
4024 | 4023 | | |
| |||
0 commit comments