Skip to content

Commit cc5d774

Browse files
author
Ming Lei
committed
nbd: restrict sockets to TCP and UDP
JIRA: https://issues.redhat.com/browse/RHEL-121713 commit 9f7c02e Author: Eric Dumazet <edumazet@google.com> Date: Tue Sep 9 13:22:43 2025 +0000 nbd: restrict sockets to TCP and UDP Recently, syzbot started to abuse NBD with all kinds of sockets. Commit cf1b232 ("nbd: verify socket is supported during setup") made sure the socket supported a shutdown() method. Explicitely accept TCP and UNIX stream sockets. Fixes: cf1b232 ("nbd: verify socket is supported during setup") Reported-by: syzbot+e1cd6bd8493060bd701d@syzkaller.appspotmail.com Closes: https://lore.kernel.org/netdev/CANn89iJ+76eE3A_8S_zTpSyW5hvPRn6V57458hCZGY5hbH_bFA@mail.gmail.com/T/#m081036e8747cd7e2626c1da5d78c8b9d1e55b154 Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Mike Christie <mchristi@redhat.com> Cc: Richard W.M. Jones <rjones@redhat.com> Cc: Jens Axboe <axboe@kernel.dk> Cc: Yu Kuai <yukuai1@huaweicloud.com> Cc: linux-block@vger.kernel.org Cc: nbd@other.debian.org Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Ming Lei <ming.lei@redhat.com>
1 parent 14c3cf9 commit cc5d774

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

drivers/block/nbd.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1217,6 +1217,14 @@ static struct socket *nbd_get_socket(struct nbd_device *nbd, unsigned long fd,
12171217
if (!sock)
12181218
return NULL;
12191219

1220+
if (!sk_is_tcp(sock->sk) &&
1221+
!sk_is_stream_unix(sock->sk)) {
1222+
dev_err(disk_to_dev(nbd->disk), "Unsupported socket: should be TCP or UNIX.\n");
1223+
*err = -EINVAL;
1224+
sockfd_put(sock);
1225+
return NULL;
1226+
}
1227+
12201228
if (sock->ops->shutdown == sock_no_shutdown) {
12211229
dev_err(disk_to_dev(nbd->disk), "Unsupported socket: shutdown callout must be supported.\n");
12221230
*err = -EINVAL;

0 commit comments

Comments
 (0)