Skip to content

Commit 336ffac

Browse files
Pavel Zhigulingregkh
authored andcommitted
net: mlxsw: linecards: fix missing error check in mlxsw_linecard_devlink_info_get()
[ Upstream commit b0c959f ] The call to devlink_info_version_fixed_put() in mlxsw_linecard_devlink_info_get() did not check for errors, although it is checked everywhere in the code. Add missed 'err' check to the mlxsw_linecard_devlink_info_get() Fixes: 3fc0c51 ("mlxsw: core_linecards: Expose device PSID over device info") Signed-off-by: Pavel Zhigulin <Pavel.Zhigulin@kaspersky.com> Reviewed-by: Ido Schimmel <idosch@nvidia.com> Link: https://patch.msgid.link/20251113161922.813828-1-Pavel.Zhigulin@kaspersky.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 470a241 commit 336ffac

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/net/ethernet/mellanox/mlxsw/core_linecards.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -601,6 +601,8 @@ int mlxsw_linecard_devlink_info_get(struct mlxsw_linecard *linecard,
601601
err = devlink_info_version_fixed_put(req,
602602
DEVLINK_INFO_VERSION_GENERIC_FW_PSID,
603603
info->psid);
604+
if (err)
605+
goto unlock;
604606

605607
sprintf(buf, "%u.%u.%u", info->fw_major, info->fw_minor,
606608
info->fw_sub_minor);

0 commit comments

Comments
 (0)