Commit 27a781e
Ming Lei
block: move hctx debugfs/sysfs registering out of freezing queue
JIRA: https://issues.redhat.com/browse/RHEL-112997
commit 9dc7a88
Author: Ming Lei <ming.lei@redhat.com>
Date: Mon May 5 22:18:00 2025 +0800
block: move hctx debugfs/sysfs registering out of freezing queue
Move hctx debugfs/sysfs register out of freezing queue in
__blk_mq_update_nr_hw_queues(), so that the following lockdep dependency
can be killed:
#2 (&q->q_usage_counter(io)#16){++++}-{0:0}:
#1 (fs_reclaim){+.+.}-{0:0}:
#0 (&sb->s_type->i_mutex_key#3){+.+.}-{4:4}: //debugfs
And registering/un-registering hctx debugfs/sysfs does not require queue to
be frozen:
- hctx sysfs attributes show() are drained when removing kobject, and
there isn't store() implementation for hctx sysfs attributes
- debugfs entry read() is drained too when removing debugfs directory,
and there isn't write() implementation for hctx debugfs too
- so it is safe to register/unregister hctx sysfs/debugfs without
freezing queue because the cod paths changes nothing, and we just
need to keep hctx live
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20250505141805.2751237-23-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Ming Lei <ming.lei@redhat.com>1 parent b8599de commit 27a781e
1 file changed
+7
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5007 | 5007 | | |
5008 | 5008 | | |
5009 | 5009 | | |
5010 | | - | |
5011 | | - | |
5012 | | - | |
5013 | 5010 | | |
5014 | 5011 | | |
5015 | 5012 | | |
5016 | 5013 | | |
5017 | 5014 | | |
| 5015 | + | |
| 5016 | + | |
| 5017 | + | |
5018 | 5018 | | |
5019 | 5019 | | |
5020 | 5020 | | |
| |||
5037 | 5037 | | |
5038 | 5038 | | |
5039 | 5039 | | |
| 5040 | + | |
| 5041 | + | |
| 5042 | + | |
| 5043 | + | |
5040 | 5044 | | |
5041 | 5045 | | |
5042 | 5046 | | |
5043 | 5047 | | |
5044 | 5048 | | |
5045 | | - | |
5046 | | - | |
5047 | | - | |
5048 | | - | |
5049 | | - | |
5050 | 5049 | | |
5051 | 5050 | | |
5052 | 5051 | | |
| |||
0 commit comments