Skip to content

Commit 26df26d

Browse files
committed
firmware: arm_ffa: Fix the partition ID check in ffa_notification_info_get()
JIRA: https://issues.redhat.com/browse/RHEL-102691 commit 1a4bd2b Author: Jens Wiklander <jens.wiklander@linaro.org> Date: Mon, 11 Mar 2024 12:07:00 +0100 FFA_NOTIFICATION_INFO_GET retrieves information about pending notifications. Notifications can be either global or per VCPU. Global notifications are reported with the partition ID only in the list of endpoints with pending notifications. ffa_notification_info_get() incorrectly expect no ID at all for global notifications. Fix this by checking for ID = 1 instead of ID = 0. Fixes: 3522be4 ("firmware: arm_ffa: Implement the NOTIFICATION_INFO_GET interface") Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> Reviewed-by: Lorenzo Pieralisi <lpieralisi@kernel.org> Link: https://lore.kernel.org/r/20240311110700.2367142-1-jens.wiklander@linaro.org Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> Signed-off-by: Marcin Juszkiewicz <mjuszkiewicz@redhat.com>
1 parent f0806b0 commit 26df26d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/firmware/arm_ffa/driver.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -790,7 +790,7 @@ static void ffa_notification_info_get(void)
790790

791791
part_id = packed_id_list[ids_processed++];
792792

793-
if (!ids_count[list]) { /* Global Notification */
793+
if (ids_count[list] == 1) { /* Global Notification */
794794
__do_sched_recv_cb(part_id, 0, false);
795795
continue;
796796
}

0 commit comments

Comments
 (0)