Skip to content

Commit 1154568

Browse files
committed
i2c: imx: add some dev_err_probe calls
JIRA: https://issues.redhat.com/browse/RHEL-116101 commit f4a5f88 Author: Alexander Stein <alexander.stein@ew.tq-group.com> Date: Tue Apr 8 12:02:59 2025 +0200 i2c: imx: add some dev_err_probe calls Add corresponding error messages if DMA channels are not available during probe. Using dev_err_probe adds deferred probe messages as well. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> Link: https://lore.kernel.org/r/20250408100300.556703-1-alexander.stein@ew.tq-group.com Signed-off-by: Andi Shyti <andi.shyti@kernel.org> Signed-off-by: Jared Kangas <jkangas@redhat.com>
1 parent 201949b commit 1154568

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

drivers/i2c/busses/i2c-imx.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1711,11 +1711,11 @@ static int i2c_imx_probe(struct platform_device *pdev)
17111711

17121712
irq = platform_get_irq(pdev, 0);
17131713
if (irq < 0)
1714-
return irq;
1714+
return dev_err_probe(&pdev->dev, irq, "can't get IRQ\n");
17151715

17161716
base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
17171717
if (IS_ERR(base))
1718-
return PTR_ERR(base);
1718+
return dev_err_probe(&pdev->dev, PTR_ERR(base), "can't get IO memory\n");
17191719

17201720
phy_addr = (dma_addr_t)res->start;
17211721
i2c_imx = devm_kzalloc(&pdev->dev, sizeof(*i2c_imx), GFP_KERNEL);
@@ -1810,13 +1810,15 @@ static int i2c_imx_probe(struct platform_device *pdev)
18101810
*/
18111811
ret = i2c_imx_dma_request(i2c_imx, phy_addr);
18121812
if (ret) {
1813-
if (ret == -EPROBE_DEFER)
1813+
if (ret == -EPROBE_DEFER) {
1814+
dev_err_probe(&pdev->dev, ret, "can't get DMA channels\n");
18141815
goto clk_notifier_unregister;
1815-
else if (ret == -ENODEV)
1816+
} else if (ret == -ENODEV) {
18161817
dev_dbg(&pdev->dev, "Only use PIO mode\n");
1817-
else
1818+
} else {
18181819
dev_warn(&pdev->dev, "Failed to setup DMA (%pe), only use PIO mode\n",
18191820
ERR_PTR(ret));
1821+
}
18201822
}
18211823

18221824
/* Add I2C adapter */

0 commit comments

Comments
 (0)