firmware: qcom: scm: Fix error code in probe()

JIRA: https://issues.redhat.com/browse/RHEL-117514

commit 7f048b2
Author: Dan Carpenter <dan.carpenter@linaro.org>
Date:   Wed Jan 15 09:52:53 2025 +0300

    firmware: qcom: scm: Fix error code in probe()

    Set the error code if devm_qcom_tzmem_pool_new() fails.  Don't return
    success.

    Fixes: 1e76b54 ("firmware: qcom: scm: Cleanup global '__scm' on probe failures")
    Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
    Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Link: https://lore.kernel.org/r/a0845467-4f83-4070-ab1e-ff7e6764609f@stanley.mountain
    Signed-off-by: Bjorn Andersson <andersson@kernel.org>

Signed-off-by: Eric Chanudet <echanude@redhat.com>

Author: eric-ch

drivers/firmware/qcom/qcom_scm.c

@@ -2301,8 +2301,8 @@ static int qcom_scm_probe(struct platform_device *pdev)
 
 	__scm->mempool = devm_qcom_tzmem_pool_new(__scm->dev, &pool_config);
 	if (IS_ERR(__scm->mempool)) {
-		dev_err_probe(__scm->dev, PTR_ERR(__scm->mempool),
-			      "Failed to create the SCM memory pool\n");
+		ret = dev_err_probe(__scm->dev, PTR_ERR(__scm->mempool),
+				    "Failed to create the SCM memory pool\n");
 		goto err;
 	}