letsplay_runner_core: Cleanup

move transport module to shared/ so that it's all nice and good

Author: modeco80

crates/letsplay_runner_core/src/client/game_thread.rs

@@ -43,12 +43,8 @@ fn main(mut rx: mpsc::UnboundedReceiver<GameThreadMessage>, mut game: Box<dyn Ga
 	// better (and properly handle states or whatever) we should probably just like... Do so?
 	let mut suspended = true;
 
-	// bring up EGL/CUDA/whatever
-
 	let contexts = GraphicsContexts::create(0);
 
-	// Spawn the video thread here
-
 	let (video_encoder_control, packet_waiter) = {
 		#[cfg(feature = "av-nvidia")]
 		{
@@ -102,7 +98,8 @@ fn main(mut rx: mpsc::UnboundedReceiver<GameThreadMessage>, mut game: Box<dyn Ga
 				}
 
 				GameThreadMessage::SetProperty { key, value, tx } => {
-					// TODO: set_property should be failable
+					// TODO: we should send the error result to the given tx
+					// so that we can propegate errors to the main thread
 					match game.set_property(&key, &value) {
 						Ok(_) => {}
 						Err(err) => {
@@ -175,14 +172,13 @@ impl GameThread {
 	}
 
 	pub async fn reset(&self) {
-		// TODO
 		let (tx, rx) = oneshot::channel();
 		let _ = self.tx.send(GameThreadMessage::Reset { tx });
 		let _ = rx.await;
 	}
 
 	pub async fn set_property(&self, key: String, value: String) {
-		// TODO
+		// TODO: This should be failable
 		let (tx, rx) = oneshot::channel();
 		let _ = self.tx.send(GameThreadMessage::SetProperty {
 			key: key.clone(),
@@ -202,8 +198,8 @@ impl GameThread {
 	}
 
 	/// Shuts down the game thread.
-	pub async fn shutdown(&self) {
+	pub async fn shutdown(self) {
 		let _ = self.tx.send(GameThreadMessage::Shutdown);
-		// TODO: join thread (or make it easier for this to be consuming)
+		self.join_handle.join().expect("Failed to join game thread");
 	}
 }

crates/letsplay_runner_core/src/client/mod.rs

@@ -3,7 +3,6 @@
 mod game;
 mod game_thread;
 mod graphics_contexts;
-mod transport;
 
 pub use game::*;
 pub use graphics_contexts::*;

crates/letsplay_runner_core/src/client/transport.rs

@@ -1 +1,3 @@
 pub mod proto;
+mod transport;
+// pub use transport::Transport;, probably

crates/letsplay_runner_core/src/shared/mod.rs

@@ -0,0 +1,15 @@
+//
+// struct Transport<RW>
+// where
+//	RW: AsyncRead + AsyncWrite + ...
+//
+// - generic over literally anything that can be read or wtitten as a stream
+//
+// Use tokio util length delimited codec
+// https://docs.rs/tokio-util/latest/tokio_util/codec/length_delimited/index.html
+//
+// Have two helpers to pull out/parse protos of the each end's roots
+// (or fail cleanly)
+//
+// guess if we *really* wanted to (I don't see it being needed since we'll only own it in
+// a fairly flat way) we could have ReadTransport<R> and WriteTransport<W> but idk