feat(sdk): introduce invocation lifecycle middleware hooks#305
Merged
manoahLinks merged 3 commits intoApr 28, 2026
Merged
Conversation
Mock next-intl, polyfill TextEncoder, and skip cargo when unavailable Made-with: Cursor
Add before/after middleware for simulate/read/write lifecycle stages Made-with: Cursor
|
@Abolax123 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds middleware support to soroban-client SDK invocation lifecycle with before and after hooks.
Supports lifecycle stages: simulate, read, prepareWrite, write, sendTransaction, and waitForTransaction.
Adds typed middleware contexts with timing/duration, success/failure, method/contract metadata, source account, and tx hash.
Adds middleware docs and dedicated tests validating hook order and error handling.
Closes #227
What changed
Updated SDK config type to accept middleware in TokenboundSdkConfig.
Added new middleware types in sdk/src/types.ts:
InvocationStage
InvocationBeforeContext
InvocationAfterContext
InvocationMiddleware
Wrapped core invocation flows in sdk/src/core.ts with middleware execution.
Added tests in sdk/src/tests/middleware.test.ts.
Added usage docs in sdk/README.md.
Test plan
npm run test --prefix soroban-client
Verified new middleware tests pass:
read/simulate hook ordering
write/send/wait hook behavior
failure propagation with after error context
Notes
This branch also includes a small local-dev compatibility commit (test: fix local pre-push and jest) so pre-push runs cleanly on environments missing cargo.