Skip to content

feat: support instance applications#322

Open
BoxBoxJason wants to merge 1 commit into
crossplane-contrib:masterfrom
BoxBoxJason:feat/instance-applications
Open

feat: support instance applications#322
BoxBoxJason wants to merge 1 commit into
crossplane-contrib:masterfrom
BoxBoxJason:feat/instance-applications

Conversation

@BoxBoxJason

Copy link
Copy Markdown
Contributor

Description of your changes

This PR adds the support of instance scoped (Oauth) Applications. This only works on self hosted instances.

This comes packaged with its full CRD api definition, controller lifecycle management logic, and associated clients methods.

Closes #321

I have:

  • Read and followed Crossplane's contribution process.
  • Followed the git conventional commit message format.
  • Made sure all changes are covered by proper tests, reaching a coverage of at least 80% when applicable.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

I have:

  • Successfully built and ran the provider locally against a kubernetes cluster.
  • Successfully created, updated, and deleted resources of the types I changed / created.
  • Ensured reconciliation loops for the changed / created resource complete without error.
    • Creation
    • Update
    • Deletion
  • Deleted the resource on the app side to ensure the provider correctly handles
    unexpected drift. (should result in recreation of the resource if applicable)
  • Updated the resource on the app side to ensure the provider correctly handles
    unexpected drift. (should result in an update of the resource if applicable)

Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support (instance) (oauth) Applications

1 participant