Fix docs, comments and enhance example

Author: baschny

README.md

@@ -176,15 +176,21 @@ replace the `.` in the settings by `__`. Examples:
 Upper case allowed (will be lower-cased):
 ```
 PHPINI__SESSION__SAVE_HANDLER=redis
+PHPINI__SESSION__SAVE_PATH='"tcp://redis:6379?persistent=1&weight=1&database=10&prefix=PHPSESSID:"'
 PHPINI__REDIS__SESSION__LOCKING_ENABLED=1
 ```
 
-Or:
+Or (lower case also fine):
 ```
 PHPFPM__request_terminate_timeout=30s
 PHPFPM__pm__max_children=15
 ```
 
+**Note**: make sure that potentially required double quotes `"` are part of the
+"string" that ends up in the ENV variable, so quote as necessary, because this
+string is copied "as is" to the ini files. See example above for the
+`PHPINI__SESSION__SAVE_PATH` - this would be the syntax for a `.env` file.
+
 ## Example usage
 
 Copy the files from `example-app/` folder to your application, tweak, and you are

example-app/.env.example

@@ -47,10 +47,11 @@ pm.max_children = 5
 # PHP settings by env vars
 # -----------------------------------------
 
-# Example of setting php.ini settings
+# Example of setting php.ini settings, UPPER CASED
 PHPINI__SESSION__SAVE_HANDLER=redis
+PHPINI__SESSION__SAVE_PATH='"tcp://redis:6379?persistent=1&weight=1&database=10&prefix=PHPSESSID:"'
 PHPINI__REDIS__SESSION__LOCKING_ENABLED=1
 
-# Example of setting PHP-FPM settings
-PHPFPM__REQUEST_terminate_timeout=30s
+# Example of setting PHP-FPM settings, lower cased also possible
+PHPFPM__request_terminate_timeout=30s
 PHPFPM__pm__max_children=15

files/entrypoint-extras.sh

@@ -103,10 +103,9 @@ if env | grep -q '^PHPINI__'; then
     # Transform key: PHPINI__this__setting => this.setting
     key=${name#PHPINI__}
     key=$(printf '%s' "$key" | sed 's/__/./g')
-    # Lowercase in POSIX sh (dash/busybox) without bash-specific substitution
     key=$(printf '%s' "$key" | tr '[:upper:]' '[:lower:]')
     # Append as "key = value" (value is written as-is; quote in ENV if needed)
-    printf '* setting in php.ini: %s = %s\n' "$key" "$value"
+    printf '* Setting in php.ini: %s = %s\n' "$key" "$value"
     printf '%s = %s\n' "$key" "$value" >> "$CUSTOM_INI"
     # Unset them, not relevant to the running containers
     unset "$name"