From 72df3397866eaeb8775cb240169dd863c3609cea Mon Sep 17 00:00:00 2001 From: Mark Ridgwell <273118822+dnyw4l3n13@users.noreply.github.com> Date: Sat, 6 Jun 2026 00:18:08 +0100 Subject: [PATCH 1/2] fix: replace raw echo with output helpers in git/mkmissing-release Replace all four bare echo calls with die/info/success helpers as defined by the shell-script output helper conventions. Prompt: Replace raw echo with output helpers in git/mkmissing-release (issue #647) Closes #647 --- git/mkmissing-release | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/git/mkmissing-release b/git/mkmissing-release index a67e7988..30ffbfeb 100755 --- a/git/mkmissing-release +++ b/git/mkmissing-release @@ -1,15 +1,28 @@ #! /bin/sh +die() { + printf '\n\033[31m✗\033[0m %s\n' "$*" >&2 + exit 1 +} + +success() { + printf '\n\033[32m✓\033[0m %s\n' "$*" +} + +info() { + printf '\n\033[32m→\033[0m %s\n' "$*" +} + BASEDIR="$(dirname "$(readlink -f "$0")")" -echo "Script Dir: $BASEDIR" +info "Script Dir: $BASEDIR" find "$(pwd)"/* -name '*.git' -print | sed "s|/.git$||" | sort -u | grep -v .cache | while IFS= read -r line do - echo "$line" + info "$line" CURRENT_DIR=$line - echo "==== $CURRENT_DIR ===" + info "==== $CURRENT_DIR ===" cd "$CURRENT_DIR" && "$BASEDIR/missing-release-branches" - echo " * done" + success " * done" done From f144a1d2c9e07f6c4b649d7a202fb4b19ed2b100 Mon Sep 17 00:00:00 2001 From: Mark Ridgwell <273118822+dnyw4l3n13@users.noreply.github.com> Date: Sat, 6 Jun 2026 00:18:37 +0100 Subject: [PATCH 2/2] chore: update changelog for fix/647-mkmissing-release-echo-helpers --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6d90ff1f..fe8da2e8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ Please ADD ALL Changes to the UNRELEASED SECTION and not a specific release - Replace raw echo with standard output helpers in git/update-dotnet-sdk - Replace raw echo with standard output helpers in git/switchtomain - Replace raw echo with output helpers in git/optimise-git +- Replace raw echo with output helpers in git/mkmissing-release ### Changed - Replace raw echo with standard output helpers (die/info/success) in github/cancel-workflows - Replace raw echo with standard output helpers (die/info/success) in git/update-repos-personal