From eadd6017e79e4d0c9d0578759ea65115efe4fab6 Mon Sep 17 00:00:00 2001 From: Mark Ridgwell <273118822+dnyw4l3n13@users.noreply.github.com> Date: Fri, 5 Jun 2026 21:32:32 +0100 Subject: [PATCH 1/2] fix: replace raw echo with standard output helpers in git/update-dotnet-sdk Prompt: Replace raw echo with output helpers in git/update-dotnet-sdk (issue #650) Closes #650 --- git/update-dotnet-sdk | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/git/update-dotnet-sdk b/git/update-dotnet-sdk index e65b808d..9cc8fbb9 100755 --- a/git/update-dotnet-sdk +++ b/git/update-dotnet-sdk @@ -1,11 +1,14 @@ #! /bin/sh die() { - echo - echo "$@" + printf '\n\033[31m✗\033[0m %s\n' "$*" >&2 exit 1 } +info() { + printf '\n\033[32m→\033[0m %s\n' "$*" +} + BASEDIR="$(dirname "$(readlink -f "$0")")" # shellcheck source=/dev/null @@ -20,7 +23,7 @@ LATEST_GA_RELEASE=$(dotnet --list-sdks | cut -f 1 -d " " | grep "^$DOTNET_PREVIE LATEST_PRE_RELEASE=$(dotnet --list-sdks | cut -f 1 -d " " | grep "^$DOTNET_PREVIEW_VERSION\.[0-9]*\.[0-9]*-" | sort | tail -1) if [ -n "$LATEST_GA_RELEASE" ]; then - echo "Latest GA release: $LATEST_GA_RELEASE"; + info "Latest GA release: $LATEST_GA_RELEASE" TMP_JSON=$(mktemp) cat "$GLOBAL_JSON" | \ @@ -36,7 +39,7 @@ if [ -n "$LATEST_GA_RELEASE" ]; then git add "$GLOBAL_JSON" && git commit "$GLOBAL_JSON" -m"Updated DotNet SDK to $LATEST_GA_RELEASE" && git push elif [ -n "$LATEST_PRE_RELEASE" ]; then - echo "Latest preview release: $LATEST_PRE_RELEASE" + info "Latest preview release: $LATEST_PRE_RELEASE" TMP_JSON=$(mktemp) cat "$GLOBAL_JSON" | \ From 285db6fb7886304ab3f73b5b3132690b645b529b Mon Sep 17 00:00:00 2001 From: Mark Ridgwell <273118822+dnyw4l3n13@users.noreply.github.com> Date: Fri, 5 Jun 2026 21:32:54 +0100 Subject: [PATCH 2/2] chore: add changelog entry for #650 --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f5568d64..835cb8a4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ Please ADD ALL Changes to the UNRELEASED SECTION and not a specific release - Replace raw echo output with standard die/success/info helpers in network/wg-create - Replace raw echo with output helpers in linux/install-fp - Replace raw echo with output helpers in git/update-preview +- Replace raw echo with standard output helpers in git/update-dotnet-sdk ### Changed - GEOIP - Updated GEOIP DB from MaxMind (2026-06-03) - Replace raw echo with standard output helpers (die/info/success) in github/cancel-workflows