From 648d0c2dd6c2dbd1ac8aec5a806528c0b25104cb Mon Sep 17 00:00:00 2001 From: Mark Ridgwell <273118822+dnyw4l3n13@users.noreply.github.com> Date: Fri, 5 Jun 2026 19:00:35 +0100 Subject: [PATCH 1/2] fix: replace raw echo with standard output helpers in git/update-preview Closes #651 Prompt: Replace raw echo with output helpers in `git/update-preview`. Replace user-facing raw `echo` usage with `die` / `info` / `success` where appropriate, preserve script behaviour, pass shell linting and repository checks. --- git/update-preview | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/git/update-preview b/git/update-preview index 5b60a819..a5978ddf 100755 --- a/git/update-preview +++ b/git/update-preview @@ -1,11 +1,18 @@ #! /bin/sh die() { - echo - echo "$@" + printf '\n\033[31m✗\033[0m %s\n' "$*" >&2 exit 1 } +success() { + printf '\n\033[32m✓\033[0m %s\n' "$*" +} + +info() { + printf '\n\033[32m→\033[0m %s\n' "$*" +} + BASEDIR="$(dirname "$(readlink -f "$0")")" # shellcheck source=/dev/null @@ -15,6 +22,6 @@ BASEDIR="$(dirname "$(readlink -f "$0")")" BRANCH="depends/sdk/dotnet/$DOTNET_PREVIEW_VERSION/preview" -echo "Using Branch: $BRANCH" +info "Using Branch: $BRANCH" git fetch && git checkout main && git pull && git checkout "$BRANCH" && git pull && rebase && update-dotnet-sdk From 608ba52cc883cc14d2150254373f76676edc467b Mon Sep 17 00:00:00 2001 From: Mark Ridgwell <273118822+dnyw4l3n13@users.noreply.github.com> Date: Fri, 5 Jun 2026 19:00:48 +0100 Subject: [PATCH 2/2] chore: add changelog entry for #651 --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4b3e8a29..f5568d64 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ Please ADD ALL Changes to the UNRELEASED SECTION and not a specific release - Shell scripts were cleaned up to pass pre-commit checks, and git/fetch now uses consistent info/success output. - Replace raw echo output with standard die/success/info helpers in network/wg-create - Replace raw echo with output helpers in linux/install-fp +- Replace raw echo with output helpers in git/update-preview ### Changed - GEOIP - Updated GEOIP DB from MaxMind (2026-06-03) - Replace raw echo with standard output helpers (die/info/success) in github/cancel-workflows