From 3e7cdc3a54cfc351f8a026091d6b6e87889ea719 Mon Sep 17 00:00:00 2001
From: Mark Ridgwell <273118822+dnyw4l3n13@users.noreply.github.com>
Date: Fri, 5 Jun 2026 18:45:32 +0100
Subject: [PATCH 1/3] fix: replace raw echo with standard output helpers in
 git/update-repos-personal
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Replace the non-standard die() function and raw echo calls with the
project-standard die/info/success helpers using coloured printf output.
Also fix shebang spacing (#! /bin/sh → #!/bin/sh).

Closes #652

Prompt: Work on issue #652 in credfeto/scripts - replace raw echo with output helpers (die, info, success) in git/update-repos-personal
---
 git/update-repos-personal | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/git/update-repos-personal b/git/update-repos-personal
index 21734a1e..cc3dda66 100755
--- a/git/update-repos-personal
+++ b/git/update-repos-personal
@@ -1,14 +1,20 @@
-#! /bin/sh
-
+#!/bin/sh
 
 die() {
-    echo
-    echo "$@"
+    printf '\n\033[31m✗\033[0m %s\n' "$*" >&2
     exit 1
 }
 
+success() {
+    printf '\n\033[32m✓\033[0m %s\n' "$*"
+}
+
+info() {
+    printf '\n\033[32m→\033[0m %s\n' "$*"
+}
+
 BASEDIR="$(dirname "$(readlink -f "$0")")"
-echo "Script Dir: $BASEDIR"
+info "Script Dir: $BASEDIR"
 
 REPOS=personal
 WORKDIR=$HOME/work/$REPOS

From 35183efe36b6feac8f2342ee730753e50fd44fcb Mon Sep 17 00:00:00 2001
From: Mark Ridgwell <273118822+dnyw4l3n13@users.noreply.github.com>
Date: Fri, 5 Jun 2026 18:45:49 +0100
Subject: [PATCH 2/3] chore: add changelog entry for #652

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index fec32a4a..4b3e8a29 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -16,6 +16,7 @@ Please ADD ALL Changes to the UNRELEASED SECTION and not a specific release
 ### Changed
 - GEOIP - Updated GEOIP DB from MaxMind (2026-06-03)
 - Replace raw echo with standard output helpers (die/info/success) in github/cancel-workflows
+- Replace raw echo with standard output helpers (die/info/success) in git/update-repos-personal
 ### Deprecated
 ### Removed
 ### Deployment Changes

From 2a212e592418d13b945345e292b02fec9f16cf09 Mon Sep 17 00:00:00 2001
From: Mark Ridgwell <273118822+dnyw4l3n13@users.noreply.github.com>
Date: Fri, 5 Jun 2026 18:49:29 +0100
Subject: [PATCH 3/3] refactor: remove unused success() helper from
 git/update-repos-personal

success() was added but is never called in this script; the script
delegates to fetch which handles its own success output per repo.
---
 git/update-repos-personal | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/git/update-repos-personal b/git/update-repos-personal
index cc3dda66..8fe0bd1a 100755
--- a/git/update-repos-personal
+++ b/git/update-repos-personal
@@ -5,10 +5,6 @@ die() {
     exit 1
 }
 
-success() {
-    printf '\n\033[32m✓\033[0m %s\n' "$*"
-}
-
 info() {
     printf '\n\033[32m→\033[0m %s\n' "$*"
 }