Skip to content

Commit 45d8140

Browse files
committed
Add proper error formating to BlobException
1 parent 3651e56 commit 45d8140

File tree

2 files changed

+13
-10
lines changed

2 files changed

+13
-10
lines changed

src/crate/client/exceptions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def __init__(self, table, digest):
8686
self.digest = digest
8787

8888
def __str__(self):
89-
return "{table}/{digest}".format(table=self.table, digest=self.digest)
89+
return f"{self.__class__.__qualname__}('{self.table}/{self.digest})'"
9090

9191

9292
class DigestNotFoundException(BlobException):

tests/client/test_exceptions.py

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
1-
import unittest
2-
31
from crate.client import Error
2+
from crate.client.exceptions import BlobException
3+
4+
5+
def test_error_with_msg():
6+
err = Error("foo")
7+
assert str(err) == "foo"
48

59

6-
class ErrorTestCase(unittest.TestCase):
7-
def test_error_with_msg(self):
8-
err = Error("foo")
9-
self.assertEqual(str(err), "foo")
10+
def test_error_with_error_trace():
11+
err = Error("foo", error_trace="### TRACE ###")
12+
assert str(err), "foo\n### TRACE ###"
1013

11-
def test_error_with_error_trace(self):
12-
err = Error("foo", error_trace="### TRACE ###")
13-
self.assertEqual(str(err), "foo\n### TRACE ###")
14+
def test_blob_exception():
15+
err = BlobException(table="sometable", digest="somedigest")
16+
assert str(err) == "BlobException('sometable/somedigest)'"

0 commit comments

Comments
 (0)