[5.x]: Empty dropdown when creating link to asset or entry (site selector?)

[btbunze]

Description

In the link modal, when selecting an asset or entry, there is a dropdown that appears empty by default and has sites as options. Trying to select one of the options doesn't change anything on the page, but results in a console warning: "No reference tag hash present in URL: ".

Note: When the "+ Choose" button is clicked, the asset/entry selector appears as expected, and you can change the site you are choosing from in that menu.

Screenshot of link modal and console warning:

Screenshot of dropdown options (sites + 'link to current site')

Steps to reproduce

1. Create a ckeditor field with link in toolbar
2. Add field to a section
3. Type and select text in field
4. Click link button
5. Select "Asset" or "Entry" from dropdown

Additional info

• Craft version: 5.9.16
• PHP version: 8.3
• Database driver & version: MYSQL 8.0
• Plugins & versions: CKEditor 5.2.0

[linear]

PT-3077

[mmikkel]

Related: #534

[i-just]

Hi, thanks for getting in touch!

Referencing what @mmikkel said under #534 - correct, it doesn’t affect which site the element selector modal opens in, but it does affect the reference tag of a selected element.

For example, you selected an entry in an installation with many entries. All you want to do is change the site of the element you want to link to. You can do it via this menu instead of having to use the replace action followed by finding the element that was already selected in another site, or going through the remove, find, select path.

The second purpose is that it gives you the ability to choose that the link should go to the current site (a bit more info: #282).

That said, you’re both right that this dropdown is confusing until an element has actually been selected, and it should be hidden until then. I just raised a PR for that.

If you’d like to test early, you can change the requirement in your composer.json to:
"craftcms/ckeditor": "5.x-dev#2188b274ae4e44a1f94665108a732c08c9155e3f as 5.3.1",
and run composer update.

[brandonkelly]

CKEditor 5.4.0 is out with the fix for this. Thanks again!