Commit 501abcf
fix(python): update custom reader tests for new execution pipeline
The "New Scale syntax and implementation" PR (posit-dev#82, 7a5ed62) introduced
a column renaming pipeline where the execution engine generates SQL
like `SELECT "x" AS "__ggsql_aes_x__"` and passes it to readers.
This requires custom readers to actually execute the SQL they receive,
since the renamed columns are expected downstream during pruning.
The custom reader tests were written with static readers that returned
hardcoded DataFrames, ignoring the SQL parameter entirely. This worked
with the old pipeline but fails with the new one because the returned
DataFrames lack the `__ggsql_aes_*` prefixed columns.
These failures were never caught on main because the Python CI workflow
only triggers on changes to `ggsql-python/**`, and posit-dev#82 only changed
`src/` files.
Changes:
- Update 4 custom reader tests to use in-memory DuckDB connections
that properly execute the SQL they receive
- Add duckdb and pyarrow as test dependencies
- Fix CI workflow to install the locally-built wheel instead of
downloading a stale version from PyPI (pip install with glob
instead of --find-links)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent fcf8c82 commit 501abcf
3 files changed
Lines changed: 35 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
34 | 35 | | |
| 36 | + | |
35 | 37 | | |
36 | 38 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
399 | 400 | | |
400 | 401 | | |
401 | 402 | | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
402 | 411 | | |
403 | | - | |
| 412 | + | |
404 | 413 | | |
405 | 414 | | |
406 | 415 | | |
| |||
411 | 420 | | |
412 | 421 | | |
413 | 422 | | |
414 | | - | |
| 423 | + | |
415 | 424 | | |
416 | 425 | | |
417 | | - | |
418 | | - | |
419 | | - | |
420 | | - | |
| 426 | + | |
421 | 427 | | |
422 | 428 | | |
423 | 429 | | |
424 | 430 | | |
425 | 431 | | |
426 | | - | |
| 432 | + | |
427 | 433 | | |
428 | 434 | | |
429 | 435 | | |
| |||
460 | 466 | | |
461 | 467 | | |
462 | 468 | | |
463 | | - | |
464 | | - | |
465 | | - | |
466 | | - | |
467 | | - | |
468 | | - | |
469 | | - | |
470 | | - | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
471 | 477 | | |
472 | 478 | | |
473 | | - | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
474 | 483 | | |
475 | 484 | | |
476 | 485 | | |
| |||
488 | 497 | | |
489 | 498 | | |
490 | 499 | | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
491 | 505 | | |
492 | 506 | | |
493 | 507 | | |
494 | 508 | | |
495 | | - | |
| 509 | + | |
496 | 510 | | |
497 | 511 | | |
498 | 512 | | |
| |||
0 commit comments