-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathA15-0-1.cpp
More file actions
220 lines (143 loc) · 3.3 KB
/
A15-0-1.cpp
File metadata and controls
220 lines (143 loc) · 3.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
// Rule: A15-0-1
// Source line: 21628
// Original file: A15-0-1.cpp
//% $Id: A15-0-1.cpp 289436 2017-10-04 10:45:23Z michal.szczepankiewicz $
#include <fstream>
#include <stdexcept>
#include <string>
#include <vector>
std::uint8_t ComputeCrc(std::string& msg);
bool IsMessageCrcCorrect1(std::string& message)
{
std::uint8_t computedCRC = ComputeCrc(message);
std::uint8_t receivedCRC = message.at(0);
if (computedCRC != receivedCRC)
{
throw std::logic_error(
"Computed CRC is invalid.");
// Non-compliant - CheckMessageCRC()
// was able to perform
// its task, nothing exceptional about its invalid result
}
return true;
}
bool IsMessageCrcCorrect2(std::string& message)
{
bool isCorrect = true;
std::uint8_t computedCRC = ComputeCrc(message);
std::uint8_t receivedCRC = message.at(0);
if (computedCRC != receivedCRC)
{
isCorrect =
false; // Compliant - if CRC is not correct, then return "false"
}
return isCorrect;
}
void SendData(std::string message)
{
if (message.empty())
{
throw std::logic_error("Preconditions are not met.");
// Compliant // SendData() was
// not able to
// perform its
// task
}
bool sendTimeoutReached = false;
// Implementation
if (sendTimeoutReached)
{
throw std::runtime_error(
"Timeout on sending a message has been reached.");
// Compliant // SendData()
// did not
// perform its
// task
}
}
std::int32_t FindIndex(std::vector<std::int32_t>& v, std::int32_t x) noexcept
{
try
{
std::size_t size = v.size();
for (std::size_t i = 0U; i < size; ++i)
{
if (v.at(i) == x) // v.at() throws an std::out_of_range exception
{
throw i; // Non-compliant - nothing exceptional about finding a
// value in vector
}
}
}
catch (std::size_t
foundIdx)
// Non-compliant - nothing exceptional about finding a
// value in vector
{
return foundIdx;
}
catch (std::out_of_range&
e) // Compliant - std::out_of_range error shall be handled
{
return -1;
}
return -1;
}
bool ReadFile(std::string& filename) noexcept
{
try
{
std::ifstream file(filename, std::ios_base::in);
if (!file.is_open())
{
throw std::runtime_error(
"File cannot be opened");
// Compliant - error on opening a
// file is an exceptional case
}
char c = file.get();
if (!file.good())
{
throw std::runtime_error(
"Cannot read from file");
}
// Compliant - error on reading from
// file is an exceptional case
}
catch (std::exception& e)
{
return false;
}
return true;
}
void Fn1(
std::uint32_t x)
// Non-compliant - inefficient and less readable version
// than its obvious alternative, e.g. fn2()
// function
{
try
{
if (x < 10)
{
throw 10;
}
// Action "A"
}
catch (std::int32_t y)
{
// Action "B"
}
}
void Fn2(
std::uint32_t x) // Compliant - the same functionality as fn1() function
{
if (x < 10)
{
// Action "B"
}
else
{
// Action "A"
}
}