From 924ef5625c44abb37093f33a87e7d10f3a8d6a9c Mon Sep 17 00:00:00 2001 From: Sergey Avseyev Date: Thu, 15 Jan 2026 09:03:36 -0800 Subject: [PATCH] [backport] Fix CI issues * lock minitest version < 6 for now (the upgrade requires extra review) release notes: https://minite.st/docs/History_rdoc.html#label-6.0.0+-2F+2025-12-17 * tune workflows to pull crash reports on macos and also run linters for maintenance branches * update gocaves mock to latest version * update core to pickup fix CXXCBC-766 Backport of #211 --- .github/workflows/linters.yml | 8 ++++++-- .github/workflows/tests.yml | 18 ++++++++++++++++++ .gitignore | 1 + Gemfile | 4 +++- bin/console | 14 ++++++++++++++ ext/couchbase | 2 +- 6 files changed, 43 insertions(+), 4 deletions(-) diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml index afcda6a3..a905c6c2 100644 --- a/.github/workflows/linters.yml +++ b/.github/workflows/linters.yml @@ -3,9 +3,13 @@ permissions: {} on: push: - branches: [ main ] + branches: + - main + - release* pull_request: - branches: [ main ] + branches: + - main + - release* env: LLVM_VERSION: 20 diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 81efb385..f881838b 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -555,6 +555,15 @@ jobs: logs/* test/**/*.{log,xml} retention-days: 5 + - name: Upload crash logs + if: failure() + uses: actions/upload-artifact@v4 + with: + name: ${{ github.job }}-${{ github.run_attempt }}-${{ matrix.ruby }}-crash + path: | + ~/Library/Logs/DiagnosticReports/ + /Library/Logs/DiagnosticReports/ + retention-days: 5 - name: Publish Test Report uses: mikepenz/action-junit-report@v4.1.0 if: always() @@ -616,6 +625,15 @@ jobs: logs/* test/**/*.{log,xml} retention-days: 5 + - name: Upload crash logs + if: failure() + uses: actions/upload-artifact@v4 + with: + name: ${{ github.job }}-${{ github.run_attempt }}-${{ matrix.ruby }}-crash + path: | + ~/Library/Logs/DiagnosticReports/ + /Library/Logs/DiagnosticReports/ + retention-days: 5 - name: Publish Test Report uses: mikepenz/action-junit-report@v4.1.0 if: always() diff --git a/.gitignore b/.gitignore index 448c2d67..78599282 100644 --- a/.gitignore +++ b/.gitignore @@ -18,6 +18,7 @@ /pkg/ /test/reports/ /tmp/ +/logs/ /vendor/bundle/ Gemfile.lock Makefile diff --git a/Gemfile b/Gemfile index e1935d30..b66a0fd3 100644 --- a/Gemfile +++ b/Gemfile @@ -30,7 +30,9 @@ group :development do gem "gem-compiler" gem "grpc-tools", "~> 1.59" gem "heckle" - gem "minitest" + gem "irb" + # TODO(SA): review https://minite.st/docs/History_rdoc.html#label-6.0.0+-2F+2025-12-17 + gem "minitest", "< 6.0" gem "minitest-reporters" gem "mutex_m" gem "rack" diff --git a/bin/console b/bin/console index 8c48bdae..650da6eb 100755 --- a/bin/console +++ b/bin/console @@ -15,6 +15,20 @@ # See the License for the specific language governing permissions and # limitations under the License. +if ARGV.delete("--trace-loaded-features") || ENV["COUCHBASE_TRACE_LOADED_FEATURES"] + loaded_before = $LOADED_FEATURES.dup + set_trace_func lambda { |event, file, line, id, _binding, _klass| + if event == 'c-return' && [:require, :load].include?(id) + new_loads = $LOADED_FEATURES - loaded_before + unless new_loads.empty? + puts "#{file}:#{line}" + new_loads.each { |path| puts " LOADED: #{path}" } + loaded_before.concat(new_loads) + end + end + } +end + require "bundler/setup" require "irb" require "open3" diff --git a/ext/couchbase b/ext/couchbase index c2439a40..8c7f8346 160000 --- a/ext/couchbase +++ b/ext/couchbase @@ -1 +1 @@ -Subproject commit c2439a404fa6b276862fe81150b1326bf98e6164 +Subproject commit 8c7f83462c8a417f78f86ab9f7bbe68ef9ee1385