Adding to group has immediate effect, removal doesn't

[fthommen]

It seems, that removing a user from a virtual group only comes into effect after this user has logged out and back in again, while adding a user has an immediate effect while the user stays logged in. The effect should probably be immediate in both directions :-)

• virtualgroup version: 2016-01-24
• DW version: Release 2015-08-10a "Detritus"

frank

[fthommen]

Addendum: Checking with "do=check" shows, that even though a user has been removed while he (or she) is logged in he (or she) still belongs to this group while the other way round, the grouplist ("You are part of the groups ...") is immediately updated.

[fthommen]

Addendum 2: I modified the groups in two ways. a) by "Add user to a group" and b) by editing a group. The effect is the same

[jkeltz]

the setGroupsUsers function in VirtualGroups.php adds new users, but doesn't look to see if old users should be removed. This can be fixed by adding to the end of this function, before $this-saveConfig line:

foreach ($config as $user => $groups) {
    if (!in_array($user, $users)) {
        if (($key = array_search($group, $groups)) !== false) {
            unset($config[$user][$key]);
         }
     }
     if ($config[$user] === []) {
         unset($config[$user]);
     }
}

The last section will remove the user if they are removed from all groups they were in.

[einhirn]

The issue here is the session cookie. It doesn't get changed once the user has logged in. Looking at the action handler that adds a virtual group for a user login, it actually can't because this plugin doesn't keep a "User X was removed from virtual group Y" list - how would we know that an existing group in the grps array was a virtual group before (instead of a regular group added by auth backend...) and we should remove it now?

virtualgroup/action.php

Line 40 in fe63800

$grps = array_unique(array_merge($USERINFO['grps'], $virtualgroups));