rename to make

Author: tymondesigns

src/Prompts/Contracts/PromptFactory.php

@@ -6,5 +6,5 @@
 
 interface PromptFactory
 {
-    public function create(string $id): PromptTemplate;
+    public function make(string $name): PromptTemplate;
 }

src/Prompts/Factories/LangfusePromptFactory.php

@@ -75,9 +75,9 @@ public function __construct(
         protected ?Closure $metadataResolver = null,
     ) {}
 
-    public function create(string $id): PromptTemplate
+    public function make(string $name): PromptTemplate
     {
-        $data = $this->getResponseContent($id);
+        $data = $this->getResponseContent($name);
 
         $builder = match ($data['type']) {
             'chat' => $this->buildChatPrompt($data),
@@ -137,7 +137,7 @@ protected function buildTextPrompt(array $data): TextPromptBuilder
     /**
      * @return LangfusePromptResponse
      */
-    protected function getResponseContent(string $id): array
+    protected function getResponseContent(string $name): array
     {
         $params = [];
 
@@ -149,7 +149,7 @@ protected function getResponseContent(string $id): array
             $params['label'] = $this->label;
         }
 
-        $uri = sprintf('%s/api/public/v2/prompts/%s', $this->baseUrl, $id);
+        $uri = sprintf('%s/api/public/v2/prompts/%s', $this->baseUrl, $name);
 
         if ($params !== []) {
             $uri .= '?' . http_build_query($params);

src/Prompts/Factories/McpPromptFactory.php

@@ -13,7 +13,7 @@
  */
 class McpPromptFactory implements PromptFactory
 {
-    public function create(string $id): PromptTemplate
+    public function make(string $name): PromptTemplate
     {
         // TODO: Implement
         return new ChatPromptTemplate([]);

tests/Unit/Prompts/Factories/LangfusePromptFactoryTest.php

@@ -62,7 +62,7 @@ function createLangfuseFactory(
         new Response(200, body: json_encode($responseData)),
     ]);
 
-    $prompt = $factory->create('test-chat-prompt');
+    $prompt = $factory->make('test-chat-prompt');
 
     expect($prompt)->toBeInstanceOf(ChatPromptTemplate::class);
     expect($prompt->messages)->toHaveCount(3);
@@ -89,7 +89,7 @@ function createLangfuseFactory(
         new Response(200, body: json_encode($responseData)),
     ]);
 
-    $prompt = $factory->create('test-text-prompt');
+    $prompt = $factory->make('test-text-prompt');
 
     expect($prompt)->toBeInstanceOf(TextPromptTemplate::class);
     expect($prompt->text)->toBe('Write a story about {{topic}}. Make it {{length}} words long.');
@@ -121,7 +121,7 @@ function createLangfuseFactory(
         new Response(200, body: json_encode($responseData)),
     ]);
 
-    $prompt = $factory->create('test-assistant-prompt');
+    $prompt = $factory->make('test-assistant-prompt');
 
     expect($prompt->messages[0])->toBeInstanceOf(UserMessage::class);
     expect($prompt->messages[1])->toBeInstanceOf(AssistantMessage::class);
@@ -143,7 +143,7 @@ function createLangfuseFactory(
         new Response(200, body: json_encode($responseData)),
     ]);
 
-    expect(fn(): PromptTemplate => $factory->create('test-prompt'))
+    expect(fn(): PromptTemplate => $factory->make('test-prompt'))
         ->toThrow(PromptException::class, 'Unsupported prompt type: unsupported');
 });
 
@@ -168,7 +168,7 @@ function createLangfuseFactory(
         new Response(200, body: json_encode($responseData)),
     ]);
 
-    expect(fn(): PromptTemplate => $factory->create('test-prompt'))
+    expect(fn(): PromptTemplate => $factory->make('test-prompt'))
         ->toThrow(PromptException::class, 'Unsupported message role: unknown');
 });
 
@@ -192,7 +192,7 @@ function createLangfuseFactory(
         new Response(200, body: json_encode($responseData)),
     ]);
 
-    expect(fn(): PromptTemplate => $factory->create('test-prompt'))
+    expect(fn(): PromptTemplate => $factory->make('test-prompt'))
         ->toThrow(PromptException::class, 'Unsupported message type: unknown');
 });
 
@@ -211,7 +211,7 @@ function createLangfuseFactory(
         new Response(200, body: json_encode($responseData)),
     ]);
 
-    $prompt = $factory->create('test-prompt');
+    $prompt = $factory->make('test-prompt');
 
     expect($prompt)->toBeInstanceOf(TextPromptTemplate::class);
 });
@@ -221,7 +221,7 @@ function createLangfuseFactory(
         new Response(404, body: 'Prompt not found'),
     ]);
 
-    expect(fn(): PromptTemplate => $factory->create('nonexistent-prompt'))
+    expect(fn(): PromptTemplate => $factory->make('nonexistent-prompt'))
         ->toThrow(PromptException::class, 'Invalid JSON response from Langfuse: Syntax error');
 });
 
@@ -230,7 +230,7 @@ function createLangfuseFactory(
         new Response(200, body: 'invalid json {'),
     ]);
 
-    expect(fn(): PromptTemplate => $factory->create('test-prompt'))
+    expect(fn(): PromptTemplate => $factory->make('test-prompt'))
         ->toThrow(PromptException::class, 'Invalid JSON response from Langfuse: Syntax error');
 });
 
@@ -270,7 +270,7 @@ function createLangfuseFactory(
     ]);
 
     /** @var \Cortex\Prompts\Templates\TextPromptTemplate $prompt */
-    $prompt = $factory->create('test-prompt');
+    $prompt = $factory->make('test-prompt');
 
     expect($prompt)->toBeInstanceOf(TextPromptTemplate::class);
     expect($prompt->metadata)->not()->toBeNull();
@@ -309,7 +309,7 @@ function createLangfuseFactory(
         new Response(200, body: json_encode($responseData)),
     ]);
 
-    $prompt = $factory->create('test-prompt');
+    $prompt = $factory->make('test-prompt');
 
     expect($prompt)->toBeInstanceOf(ChatPromptTemplate::class);
     expect($prompt->metadata)->not()->toBeNull();
@@ -342,7 +342,7 @@ function createLangfuseFactory(
         new Response(200, body: json_encode($responseData)),
     ]);
 
-    $prompt = $factory->create('test-prompt');
+    $prompt = $factory->make('test-prompt');
 
     expect($prompt->metadata)->not()->toBeNull();
     expect($prompt->metadata->provider)->toBe('anthropic');
@@ -390,7 +390,7 @@ function createLangfuseFactory(
         );
     });
 
-    $prompt = $factory->create('test-prompt');
+    $prompt = $factory->make('test-prompt');
 
     expect($prompt->metadata)->not()->toBeNull();
     expect($prompt->metadata->provider)->toBe('custom-provider');
@@ -438,7 +438,7 @@ function createLangfuseFactory(
         new Response(200, body: json_encode($responseData)),
     ]);
 
-    $prompt = $factory->create('test-prompt');
+    $prompt = $factory->make('test-prompt');
 
     expect($prompt)->toBeInstanceOf(ChatPromptTemplate::class);
     expect($prompt->metadata)->not()->toBeNull();