Skip to content

Commit 01538ff

Browse files
authored
Fix dspy task 8635: change min_instr_chars default from 30 to 0 (#40)
The combined.patch adds instruction length bounds with min_instr_chars=30. The pre-existing test test_propose_instructions_for_program[None] uses DummyLM which returns "instruction" (11 chars). This falls below the 30-char minimum, causing the code to fall back to the default signature instruction, breaking the assertion. tests2.patch corrects this assertion but tests1.patch does not, so feature 1 tests always fail. Changing the default to 0 preserves backward compatibility while keeping the length-bounds feature functional when explicitly configured.
1 parent f4a5608 commit 01538ff

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

dataset/dspy_task/task8635/combined.patch

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ index 13722b4b..2d60a9b6 100644
5151
use_tip=True,
5252
verbose=False,
5353
+ max_description_chars=2000,
54-
+ min_instr_chars=30,
54+
+ min_instr_chars=0,
5555
+ max_instr_chars=600,
5656
+ rephrase_when_too_long=False,
5757
):
@@ -201,7 +201,7 @@ index 13722b4b..2d60a9b6 100644
201201
+ max_instruct_history=5,
202202
+ tip_weights=None,
203203
+ max_description_chars=2000,
204-
+ min_instr_chars=30,
204+
+ min_instr_chars=0,
205205
+ max_instr_chars=600,
206206
+ rephrase_when_too_long=False,
207207
):

0 commit comments

Comments
 (0)