Commit 01538ff
authored
Fix dspy task 8635: change min_instr_chars default from 30 to 0 (#40)
The combined.patch adds instruction length bounds with min_instr_chars=30.
The pre-existing test test_propose_instructions_for_program[None] uses
DummyLM which returns "instruction" (11 chars). This falls below the
30-char minimum, causing the code to fall back to the default signature
instruction, breaking the assertion.
tests2.patch corrects this assertion but tests1.patch does not, so
feature 1 tests always fail.
Changing the default to 0 preserves backward compatibility while keeping
the length-bounds feature functional when explicitly configured.1 parent f4a5608 commit 01538ff
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
204 | | - | |
| 204 | + | |
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
| |||
0 commit comments