code clean-up

Author: ishaileshmishra

.gitignore

@@ -15,6 +15,7 @@ config.py/
 /reports
 /tests/reports
 # Distribution / packaging
+.dccache
 .Python
 build/
 develop-eggs/

CHANGELOG.md

@@ -4,7 +4,7 @@
 
 ============
 
-**Date: 1-Aug-2021**
+### Date: 1-Aug-2021
 
 Issue #17 resolved.
 Stack.sync_init uses wrong parameter names
@@ -13,22 +13,20 @@ Stack.sync_init uses wrong parameter names
 
 ============
 
-**Date: 22-Jul-2021**
+### Date: 22-Jul-2021
 
 contentstack-utils updated to v1.1.0
 
 ## _v1.4.0_
 
 ============
 
-**Date: 05-Apr-2021**
+### Date: 05-Apr-2021
 
-Entry
-    - include_embedded_objects support added
-Query
-    - include_embedded_objects support added
+Entry - include_embedded_objects support added
+Query - include_embedded_objects support added
 
------------------------------
+---
 
 ## _v1.3.0_
 
@@ -39,7 +37,7 @@ Date: 26-Feb-2021
 - Retry policy and timeout support included
 - Set default timeout 30 sec
 
------------------------------
+---
 
 ## _v1.2.0_
 
@@ -59,7 +57,7 @@ Date: 08-Dec-2020
 - Query
   - added support for include_fallback.
 
------------------------------
+---
 
 ## _v1.1.0_
 
@@ -69,7 +67,7 @@ EntryQueryable
 
 - updated include_reference function.
 
------------------------------
+---
 
 ## _v1.0.0_
 
@@ -93,12 +91,12 @@ Query
 
 - Changes incorporated in the Query class.
 
------------------------------
+---
 
 ## _v0.1.0_
 
 November-18, 2019 -beta release
 
 Initial release for the contentstack-python-sdk for Content Delivery API
 
------------------------------
+---

contentstack/assetquery.py

@@ -27,7 +27,8 @@ def __init__(self, http_instance):
         self.base_url = "{}/assets".format(self.http_instance.endpoint)
         if "environment" in self.http_instance.headers:
             env = self.http_instance.headers["environment"]
-            self.base_url = "{}?{}".format(self.base_url, "environment={}".format(env))
+            self.base_url = "{}?{}".format(
+                self.base_url, "environment={}".format(env))
 
     def environment(self, environment):
         r"""Provide the name of the environment if you wish to retrieve the assets published

contentstack/basequery.py

@@ -35,7 +35,8 @@ class QueryOperation(enum.Enum):
 
 
 def _get_operation_value(fields):
-    value = fields[0] if isinstance(fields, list) and len(fields) == 1 else fields
+    value = fields[0] if isinstance(
+        fields, list) and len(fields) == 1 else fields
     return value
 
 

contentstack/contenttype.py

@@ -16,6 +16,7 @@
 
 log = logging.getLogger(__name__)
 
+
 class ContentType:
     """
     Content type defines the structure or schema of a page or a
@@ -49,7 +50,8 @@ def entry(self, entry_uid: str):
             raise PermissionError('Please provide valid content_type_uid')
         if entry_uid is None:
             raise PermissionError('Please provide valid entry uid')
-        entry = Entry(self.http_instance, self.__content_type_uid, entry_uid=entry_uid)
+        entry = Entry(self.http_instance,
+                      self.__content_type_uid, entry_uid=entry_uid)
         return entry
 
     def query(self):
@@ -84,9 +86,11 @@ def fetch(self):
         ------------------------------
         """
         if self.__content_type_uid is None:
-            raise KeyError('content_type_uid can not be None to fetch contenttype')
+            raise KeyError(
+                'content_type_uid can not be None to fetch contenttype')
         self.local_param['environment'] = self.http_instance.headers['environment']
-        uri = '{}/content_types/{}'.format(self.http_instance.endpoint, self.__content_type_uid)
+        uri = '{}/content_types/{}'.format(
+            self.http_instance.endpoint, self.__content_type_uid)
         encoded_params = parse.urlencode(self.local_param)
         url = '{}?{}'.format(uri, encoded_params)
         result = self.http_instance.get(url)
@@ -111,6 +115,7 @@ def find(self, params=None):
         if params is not None:
             self.local_param.update(params)
         encoded_params = parse.urlencode(self.local_param)
-        url = '{}?{}'.format('{}/content_types'.format(self.http_instance.endpoint), encoded_params)
+        url = '{}?{}'.format(
+            '{}/content_types'.format(self.http_instance.endpoint), encoded_params)
         result = self.http_instance.get(url)
         return result

contentstack/https_connection.py

@@ -63,13 +63,16 @@ def get(self, url):
             adapter = HTTPAdapter(max_retries=self.retry_strategy)
             session.mount('https://', adapter)
             # log.info('url: %s', url)
-            response = session.get(url, verify=True, headers=self.headers, timeout=self.timeout)
+            response = session.get(
+                url, verify=True, headers=self.headers, timeout=self.timeout)
+            session.close()
             if response.encoding is None:
                 response.encoding = 'utf-8'
             if response is not None:
                 return response.json()
             else:
                 return {"error": "error details not found", "error_code": 422, "error_message": "unknown error"}
+
         except Timeout:
             raise TimeoutError('The request timed out')
         except ConnectionError:

contentstack/image_transform.py

@@ -13,6 +13,7 @@
 
 log = logging.getLogger(__name__)
 
+
 class ImageTransform:  # pylint: disable=too-few-public-methods
     """
     The Image Delivery API is used to retrieve, manipulate and/or convert image
@@ -51,7 +52,8 @@ def get_url(self):
         ------------------------------
         """
         # args = ['{0}={1}'.format(k, v) for k, v in self.image_params.items()]
-        args = ['{0}={1}'.format(k, v) for k, v in list(self.image_params.items())]
+        args = ['{0}={1}'.format(k, v)
+                for k, v in list(self.image_params.items())]
         if args:
             self.image_url += '?{0}'.format('&'.join(args))
         return self.image_url

package.json

@@ -1,9 +1,9 @@
 {
-  "name": "contentstack.python",
-  "version": "1.5.1",
-  "developer": "shaileshmishra",
-  "license": "MIT",
-  "author": {"name": "shaileshmishra", "email": "mshaileshr@gmail.com"},
-  "homepage": "www.contentstack.com",
-  "readme": "./readme"
-}
+    "name": "contentstack.python",
+    "version": "1.5.1",
+    "developer": "ishaileshmishra",
+    "license": "MIT",
+    "author": { "name": "shaileshmishra", "email": "mshaileshr@gmail.com" },
+    "homepage": "www.contentstack.com",
+    "readme": "./readme"
+}