Insufficient explanation for service configuration in "Routing"

[falkgeist]

I am not sure if I am misunderstanding, but it seems that the example is not helping quite enough to show how to implement the service as public or tag it with the controller.service_arguments tag...

Admittedly, the AsController attribute does that, but from the text and the code, this is not exactly clear for anyone.

It would help in my opinion if this explanation from the Symfony docs is either referenced or quoted, adding the information about when and how to use which method: AbstractController, AsController or manual controller.service_arguments tag. Although I do think the latter should probably be omitted from the Contao docs and only referenced...

(What added to my confusion, but is an honest mistake, was the leftover use for the ServiceTag annotation and the Routing annotation. 😉)

docs/docs/dev/framework/routing/_index.md

Lines 108 to 140 in 393e459

	When using controllers as services and taking advantage of dependency injection,
	the controller's service needs to be set to `public` or be tagged with the
	`controller.service_arguments` tag.
	```php
	// src/Controller/ExampleController.php
	namespace App\Controller;
	use Symfony\Component\HttpFoundation\Response;
	use Symfony\Component\HttpKernel\Attribute\AsController;
	use Symfony\Component\Routing\Annotation\Route;
	use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
	use Terminal42\ServiceAnnotationBundle\Annotation\ServiceTag;
	#[Route('/example', name: ExampleController::class)]
	#[AsController]
	class ExampleController
	{
	public function __construct(
	private readonly AuthorizationCheckerInterface $authorizationChecker
	) {
	}
	public function __invoke(): Response
	{
	if ($this->authorizationChecker->isGranted('ROLE_MEMBER')) {
	return new Response('Member is logged in.');
	}
	return new Response ('Member is not logged in.');
	}
	}
	```

I am happy to provide a PR, but I wanted to check first if I misunderstood or not.

[fritzmg]

Yeah, for sure. I'd just add

Using the AsController PHP attribute would be one way to achieve this:

to the first paragraph (with a link to the Symfony documentation).

[fritzmg]

(What added to my confusion, but is an honest mistake, was the leftover use for the ServiceTag annotation and the Routing annotation. 😉)

In Symfony 5 the attribute still lived there. Symfony 6 kept it there for BC as well, so that you can be compatible with both Symfony 5 and 6.

However, now that we are on Contao 5 and thus at least Symfony 6 we could change the examples to use the new FQCN, yes.