From 3f72f32558701502f4a5e06cc7ac3f6275374ee8 Mon Sep 17 00:00:00 2001 From: Kir Kolyshkin Date: Thu, 12 Feb 2026 14:47:10 -0800 Subject: [PATCH] ci: simplify codespell job We don't really need to run Fedora container in order to execute codespell. Inspired by a recent dockerhub reject. Notes: - we use pip so we don't depend on whatever version is installed on the host (Ubuntu); - since Ubuntu 24.04, --break-system-packages is required; - we use a specified version to avoid unexpected CI failures caused by newer codespell. While at it, remove an exclusion from .codespellrc -- apparently no longer needed. Signed-off-by: Kir Kolyshkin --- .codespellrc | 2 +- .github/workflows/test.yaml | 4 ++-- tests/codespell/Dockerfile | 3 --- 3 files changed, 3 insertions(+), 6 deletions(-) delete mode 100644 tests/codespell/Dockerfile diff --git a/.codespellrc b/.codespellrc index 9ee8302398..de31ee25d6 100644 --- a/.codespellrc +++ b/.codespellrc @@ -1,4 +1,4 @@ [codespell] skip = libocispec,build-aux,contrib,*.1,.git,configure,Makefile,libtool,m4,autom4te.cache,*.m4,*.mk count = -ignore-words-list = trun,ser +ignore-words-list = ser diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index e8d88b0ad8..ab86b87736 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -186,8 +186,8 @@ jobs: sudo docker run --cgroupns=host -e RUN_TIME=300 --privileged --rm -v /sys/fs/cgroup:/sys/fs/cgroup:rw,rslave -v ${PWD}:/crun crun-fuzzing ;; codespell) - sudo docker build -t crun-codespell tests/codespell - sudo docker run --rm -w /crun -v ${PWD}:/crun crun-codespell codespell -q 0 + pip install --break-system-packages codespell==v2.4.1 # Use known version + codespell ;; wasmedge-build) sudo docker build -t wasmedge tests/wasmedge-build diff --git a/tests/codespell/Dockerfile b/tests/codespell/Dockerfile deleted file mode 100644 index f34415e993..0000000000 --- a/tests/codespell/Dockerfile +++ /dev/null @@ -1,3 +0,0 @@ -FROM fedora:latest - -RUN dnf install -y awk codespell && yum clean all -y