Should `setenv()` return value be checked?

[eriksjolund]

Is there a need to check the return value of setenv()?

$ git grep setenv
src/libcrun/container.c:          setenv ("HOME", "/", 1);
src/libcrun/container.c:      setenv ("LISTEN_PID", "1", 1);
src/libcrun/container.c:          setenv ("HOME", "/", 1);
src/libcrun/utils.c:          setenv ("HOME", ret_pw->pw_dir, 1);

(The result is from git commit d0c1224)

[giuseppe]

yes, I think we should check for errors to avoid unpredictable results in the container.

Would you like to open a PR?

[eriksjolund]

I opened #2007