Pass Runtime.systemContext whenever possible

Signed-off-by: Miloslav Trmač <mitr@redhat.com>

Author: mtrmac

common/libimage/image.go

@@ -97,7 +97,7 @@ func (i *Image) isCorrupted(ctx context.Context, name string) error {
 		return err
 	}
 
-	img, err := ref.NewImage(ctx, nil)
+	img, err := ref.NewImage(ctx, &i.runtime.systemContext)
 	if err != nil {
 		if name == "" {
 			name = i.ID()[:12]

common/libimage/manifest_list.go

@@ -235,6 +235,9 @@ func (i *Image) ConvertToManifestList(ctx context.Context) (*ManifestList, error
 	// Copy from the OCI layout into the same image record, so that it gets
 	// both its own manifest and the image index.
 	copyOptions := imageCopy.Options{
+		SourceCtx:      &i.runtime.systemContext,
+		DestinationCtx: &i.runtime.systemContext,
+
 		ForceManifestMIMEType: imageManifestType,
 	}
 	if _, err := imageCopy.Image(ctx, policyContext, i.storageReference, bundle, &copyOptions); err != nil {
@@ -561,6 +564,9 @@ func (m *ManifestList) AddArtifact(ctx context.Context, options *ManifestListAdd
 	if options == nil {
 		options = &ManifestListAddArtifactOptions{}
 	}
+
+	systemContext := m.image.runtime.systemContextCopy()
+
 	opts := manifests.AddArtifactOptions{
 		ManifestArtifactType: options.Type,
 		Annotations:          maps.Clone(options.Annotations),
@@ -592,7 +598,7 @@ func (m *ManifestList) AddArtifact(ctx context.Context, options *ManifestListAdd
 		opts.LayerMediaType = &options.LayerType
 	}
 	if options.Subject != "" {
-		ref, err := m.parseNameToExtantReference(ctx, nil, options.Subject, true, "subject for artifact manifest")
+		ref, err := m.parseNameToExtantReference(ctx, systemContext, options.Subject, true, "subject for artifact manifest")
 		if err != nil {
 			return "", err
 		}
@@ -607,8 +613,6 @@ func (m *ManifestList) AddArtifact(ctx context.Context, options *ManifestListAdd
 	locker.Lock()
 	defer locker.Unlock()
 
-	systemContext := m.image.runtime.systemContextCopy()
-
 	// Make sure to reload the image from the containers storage to fetch
 	// the latest data (e.g., new or delete digests).
 	if err := m.reload(); err != nil {
@@ -709,7 +713,7 @@ func (m *ManifestList) AnnotateInstance(d digest.Digest, options *ManifestListAn
 		}
 	}
 	if options.Subject != "" {
-		ref, err := m.parseNameToExtantReference(ctx, nil, options.Subject, true, "subject for image index")
+		ref, err := m.parseNameToExtantReference(ctx, &m.image.runtime.systemContext, options.Subject, true, "subject for image index")
 		if err != nil {
 			return err
 		}

common/libimage/pull.go

@@ -257,7 +257,7 @@ func (r *Runtime) copyFromDefault(ctx context.Context, ref types.ImageReference,
 		if !ok || refName == "" {
 			// Same trick as for the dir transport: we cannot use
 			// the path to a directory as the name.
-			storageName, err = getImageID(ctx, ref, nil)
+			storageName, err = getImageID(ctx, ref, &r.systemContext)
 			if err != nil {
 				return nil, nil, err
 			}
@@ -276,7 +276,7 @@ func (r *Runtime) copyFromDefault(ctx context.Context, ref types.ImageReference,
 		switch len(storageName) {
 		case 0:
 			// If there's no reference name in the annotations, compute an ID.
-			storageName, err = getImageID(ctx, ref, nil)
+			storageName, err = getImageID(ctx, ref, &r.systemContext)
 			if err != nil {
 				return nil, nil, err
 			}
@@ -302,7 +302,7 @@ func (r *Runtime) copyFromDefault(ctx context.Context, ref types.ImageReference,
 		// Path-based transports (e.g., dir) may include invalid
 		// characters, so we should pessimistically generate an ID
 		// instead of looking at the StringWithinTransport().
-		storageName, err = getImageID(ctx, ref, nil)
+		storageName, err = getImageID(ctx, ref, &r.systemContext)
 		if err != nil {
 			return nil, nil, err
 		}