chore: only upload coverage on Java 25#139
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts CI/Gradle behavior so coverage is only uploaded once per workflow run (on Java 25), while still allowing the sshlib tests to execute under the matrix-selected JDK via Gradle toolchains.
Changes:
- Add a
jdkVersionGradle property to select the Java toolchain launcher used by thesshlib:testtask. - Gate the “Upload coverage to Qlty” CI step to run only on the Java 25 matrix entry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
sshlib/build.gradle.kts |
Configures the test task to run with a toolchain-selected JDK version from -PjdkVersion (default 17). |
.github/workflows/ci.yml |
Uploads coverage to Qlty only when matrix.java is 25. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| useJUnitPlatform() | ||
| javaLauncher.set( | ||
| javaToolchains.launcherFor { | ||
| languageVersion.set(JavaLanguageVersion.of(testJdkVersion.get())) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.