More tests#138
Merged
Merged
Conversation
The disconnectedFlow might have fired before we were able to capture the event.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds additional unit tests around the SFTP result/type model and the Java-reflection-based ML-KEM provider, and expands CI coverage to run the build on Java 25.
Changes:
- Added equals/hashCode verification tests for several SFTP value types.
- Added behavioral tests for
SftpResultconvenience helpers and for SFTP attribute decoding of extended attributes. - Added a comprehensive test suite for
JavaMlKemProvider, plus CI matrix expansion to Java 25.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sshlib/src/test/kotlin/org/connectbot/sshlib/SftpTypesTest.kt | Adds EqualsVerifier tests for SFTP type equality/hashCode and SftpStatusCode.fromCode. |
| sshlib/src/test/kotlin/org/connectbot/sshlib/SftpResultTest.kt | Adds EqualsVerifier + behavior tests for SftpResult.getOrNull/getOrThrow. |
| sshlib/src/test/kotlin/org/connectbot/sshlib/crypto/JavaMlKemProviderTest.kt | Adds tests for ML-KEM provider behavior, X.509 wrap/extract, and error wrapping (uses reflection/Unsafe). |
| sshlib/src/test/kotlin/org/connectbot/sshlib/client/sftp/SftpRawPacketTest.kt | Adds EqualsVerifier test for raw SFTP packet equality/hashCode. |
| sshlib/src/test/kotlin/org/connectbot/sshlib/client/sftp/SftpFileAttributesTest.kt | Adds a regression test ensuring extended attributes are skipped/consumed correctly. |
| .github/workflows/ci.yml | Expands CI Java matrix to include Java 25. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This requires adding Java 25 to the test matrix.
Import classes when needed instead of referring to them by fully-qualified class name.
kruton
force-pushed
the
more-tests
branch
2 times, most recently
from
7d2ab0f to
ccab199
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.