Install Swift toolchain for more build steps #1060
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Dec 5, 2025
Owner
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
The change contents look right, but I'm not sure I understand the commit message. The lld that should be used is the one from the toolchain that we are using to build. If that is a prebuilt Swift toolchain, it would be that one. But, if we build with a clang from llvm.org, it should be that.
Is this change just for lld?
Collaborator
Author
|
When do we ever build with a Clang from llvm.org? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Clang build relies on the clang/lld that come with the Swift toolchain, or it should. As it happens, Github runners preinstall Clang, so in jobs where we weren't installing a Swift toolchain as part of the
setup-buildaction, we were relying on that. This doesn't work on CIRun runners.This change adds an install of the pinned Swift toolchain to almost every step that wasn't previously doing so. The exception is a few steps where we install a previously-built compiler, which seems to cause a conflict.
Downstream run (with host toolchain; main purpose was to make sure we don't break the default build):
https://github.com/thebrowsercompany/swift-build/actions/workflows/build-toolchain.yml