Skip to content

Commit a054f7b

Browse files
authored
Merge pull request #17 from commitdev/fix-missing-output-file
fix: missing module output file
2 parents 7c04de0 + 17bfcb0 commit a054f7b

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

kubernetes/terraform/modules/kubernetes/kubernetes_dashboard.tf

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ resource "kubernetes_service_account" "kubernetes_dashboard_user" {
33
name = "dashboard-user"
44
namespace = "kubernetes-dashboard"
55
}
6+
depends_on = [kubernetes_namespace.kubernetes_dashboard]
67
}
78

89
resource "kubernetes_cluster_role_binding" "kubernetes_dashboard_user" {
@@ -33,6 +34,7 @@ resource "kubernetes_service_account" "kubernetes_dashboard" {
3334
namespace = "kubernetes-dashboard"
3435
labels = { k8s-app = "kubernetes-dashboard" }
3536
}
37+
depends_on = [kubernetes_namespace.kubernetes_dashboard]
3638
}
3739

3840
resource "kubernetes_service" "kubernetes_dashboard" {

terraform/modules/database/main.tf

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,10 @@ data "aws_caller_identity" "current" {
3030

3131
# creating RDS password in secret-manager
3232
module "db_password" {
33-
source = "../secret"
34-
name_prefix = "${var.project}-${var.environment}-rds-master-password"
35-
type = "random"
33+
source = "../secret"
34+
type = "random"
35+
## note: secret name_prefix has a limitation of 32 characters
36+
name_prefix = "${var.project}-${var.environment}-rds"
3637
}
3738

3839
# RDS does not support secret-manager, have to provide the actual string

terraform/modules/secret/output.tf

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
output "secret_name" {
2+
value = aws_secretsmanager_secret.secret.name
3+
}

0 commit comments

Comments
 (0)