fix: improve affected, callers, and context precision#358
Open
bohe76 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR combines three small CodeGraph precision improvements that were tested together:
affectedby considering symbol-level edges and normalizing Windows-style pathsinstantiatesedges in caller lookup so class construction is reported as usagecontextentry points and keep output focused with fewer default code blocks plus compact same-file focus snippetsThese changes are also available as split PRs for easier review:
affectedsemantic dependentsLocal evaluation
I ran the same 14-case local smoke suite against
origin/mainbefore these changes and against this combined branch.f366222Compared with baseline, the combined branch reduces CodeGraph output tokens by 8,685 tokens, or 49.2%, while passing 8 additional cases.
Token estimate method:
ceil(character_count / 4)over prompt-visible command output. The smoke accuracy checks are string-presence checks for expected files/symbols, not a claim of semantic completeness.Testing
npm run buildnpx vitest run __tests__/graph.test.ts __tests__/context.test.ts --minWorkers=1 --maxWorkers=1 --testTimeout=30000 --hookTimeout=30000 --no-file-parallelism