rename isEnabled to isOn

Author: JonathanLouw

README.md

@@ -95,7 +95,7 @@ FeatureState::dynamic()
 ```php
 use Codinglabs\FeatureFlags\Facades\FeatureFlag;
 
-if (FeatureFlag::isEnabled('search-v2')) {
+if (FeatureFlag::isOn('search-v2')) {
     // new feature code
 } else {
     // old code
@@ -178,7 +178,7 @@ If a handler for missing features has been defined then an exception will **not*
 Inertia::share([
     'features' => function () {
         return collect(config('app.features'))
-            ->filter(fn ($feature) => FeatureFlag::isEnabled($feature['name']))
+            ->filter(fn ($feature) => FeatureFlag::isOn($feature['name']))
             ->pluck('name');
     }
 ]);

config/feature-flags.php

@@ -11,7 +11,8 @@
     | feature. You can also configure a prefix for all keys in the cache.
     */
 
-    'cache_store' => env('FEATURES_CACHE_STORE'),
+    'cache_store' => env('FEATURES_CACHE_STORE', config('cache.default')),
+
     'cache_prefix' => 'features',
 
     /*

src/Facades/FeatureFlag.php

@@ -8,7 +8,7 @@
 /**
  * @see \Codinglabs\FeatureFlags\FeatureFlags
  *
- * @method static bool isEnabled(string $feature)
+ * @method static bool isOn(string $feature)
  * @method static void updateFeatureState(string $feature, FeatureState $state)
  * @method static void turnOn(string $feature)
  * @method static void turnOff(string $feature)

src/FeatureFlags.php

@@ -18,7 +18,7 @@ class FeatureFlags
 
     private static function cache(): Repository
     {
-        return Cache::store(config('feature-flags.cache_store'));
+        return Cache::store(config('feature-flags.cache_store', config('cache.default')));
     }
 
     public static function getFeatureCacheKey(string $feature): string
@@ -69,7 +69,7 @@ public static function handleMissingFeatureWith(Closure $closure): void
         self::$handleMissingFeatureClosure = $closure;
     }
 
-    public static function isEnabled(string $feature): bool
+    public static function isOn(string $feature): bool
     {
         return match (self::getState($feature)) {
             FeatureState::on() => true,

src/FeatureFlagsServiceProvider.php

@@ -27,7 +27,7 @@ public function packageRegistered()
     public function packageBooted()
     {
         Blade::if('feature', function ($value) {
-            return FeatureFlag::isEnabled($value);
+            return FeatureFlag::isOn($value);
         });
     }
 }

tests/FeaturesTest.php

@@ -18,10 +18,10 @@
     FeatureFlag::reset();
 });
 
-it('throws an exception if calling isEnabled for a feature that does not exist', function () {
+it('throws an exception if calling isOn for a feature that does not exist', function () {
     $this->expectException(MissingFeatureException::class);
 
-    FeatureFlag::isEnabled('some-feature');
+    FeatureFlag::isOn('some-feature');
     expect(cache()->store('array')->get('testing.some-feature'))->toBeNull();
 });
 
@@ -36,31 +36,31 @@
         // handling...
     });
 
-    expect(FeatureFlag::isEnabled('some-feature'))->toBeFalse();
+    expect(FeatureFlag::isOn('some-feature'))->toBeFalse();
     expect(cache()->store('array')->get('testing.some-feature'))->toBeNull();
 });
 
-it('resolves isEnabled to false when the features state is "off"', function () {
+it('resolves isOn to false when the features state is "off"', function () {
     Feature::factory()->create([
         'name' => 'some-feature',
         'state' => FeatureState::off()
     ]);
 
-    expect(FeatureFlag::isEnabled('some-feature'))->toBeFalse();
+    expect(FeatureFlag::isOn('some-feature'))->toBeFalse();
     expect(cache()->store('array')->get('testing.some-feature'))->toBe(FeatureState::off()->value);
 });
 
-it('resolves isEnabled to true when the features state is "on"', function () {
+it('resolves isOn to true when the features state is "on"', function () {
     Feature::factory()->create([
         'name' => 'some-feature',
         'state' => FeatureState::on()
     ]);
 
-    expect(FeatureFlag::isEnabled('some-feature'))->toBeTrue();
+    expect(FeatureFlag::isOn('some-feature'))->toBeTrue();
     expect(cache()->store('array')->get('testing.some-feature'))->toBe(FeatureState::on()->value);
 });
 
-it('resolves isEnabled to true when feature state is "restricted" and the closure returns true', function () {
+it('resolves isOn to true when feature state is "dynamic" and the closure returns true', function () {
     Feature::factory()->create([
         'name' => 'some-feature',
         'state' => FeatureState::dynamic(),
@@ -70,11 +70,11 @@
         return true;
     });
 
-    expect(FeatureFlag::isEnabled('some-feature'))->toBeTrue();
+    expect(FeatureFlag::isOn('some-feature'))->toBeTrue();
     expect(cache()->store('array')->get('testing.some-feature'))->toBe(FeatureState::dynamic()->value);
 });
 
-it('resolves isEnabled to false when feature state is "restricted" and the closure returns false', function () {
+it('resolves isOn to false when feature state is "dynamic" and the closure returns false', function () {
     Feature::factory()->create([
         'name' => 'some-feature',
         'state' => FeatureState::dynamic(),
@@ -84,11 +84,11 @@
         return false;
     });
 
-    expect(FeatureFlag::isEnabled('some-feature'))->toBeFalse();
+    expect(FeatureFlag::isOn('some-feature'))->toBeFalse();
     expect(cache()->store('array')->get('testing.some-feature'))->toBe(FeatureState::dynamic()->value);
 });
 
-it('uses the default restricted closure if no feature specific closure has been defined', function () {
+it('uses the default dynamic closure if no feature specific closure has been defined', function () {
     Feature::factory()->create([
         'name' => 'some-feature',
         'state' => FeatureState::dynamic(),
@@ -98,17 +98,17 @@
         return true;
     });
 
-    expect(FeatureFlag::isEnabled('some-feature'))->toBeTrue();
+    expect(FeatureFlag::isOn('some-feature'))->toBeTrue();
     expect(cache()->store('array')->get('testing.some-feature'))->toBe(FeatureState::dynamic()->value);
 });
 
-it('resolves isEnabled to false when feature state is "restricted" and no restricted closure has been defined', function () {
+it('resolves isOn to false when feature state is "dynamic" and no dynamic closure has been defined', function () {
     Feature::factory()->create([
         'name' => 'some-feature',
         'state' => FeatureState::dynamic(),
     ]);
 
-    expect(FeatureFlag::isEnabled('some-feature'))->toBeFalse();
+    expect(FeatureFlag::isOn('some-feature'))->toBeFalse();
 });
 
 it('can update a features state', function () {
@@ -124,6 +124,14 @@
     FeatureFlag::updateFeatureState('some-feature', FeatureState::on());
 
     Event::assertDispatched(\Codinglabs\FeatureFlags\Events\FeatureUpdatedEvent::class);
-    expect(FeatureFlag::isEnabled('some-feature'))->toBeTrue();
+    expect(FeatureFlag::isOn('some-feature'))->toBeTrue();
     expect(cache()->store('array')->get('testing.some-feature'))->toBe(FeatureState::on()->value);
 });
+
+it('uses the default cache store when cache store has not been set', function() {
+    config(['cache.default' => 'file']);
+
+    config(['feature-flags.cache_store' => env('FEATURES_CACHE_STORE', config('cache.default'))]);
+
+    expect(config('feature-flags.cache_store'))->toBe('file');
+});