Use route() helper for named routes to support translated slugs

Author: ivanvermeyen

src/LocalizedUrlGenerator.php

@@ -8,6 +8,7 @@
 use Illuminate\Support\Facades\Config;
 use Illuminate\Support\Facades\Request;
 use Illuminate\Support\Facades\Route;
+use Symfony\Component\Routing\Exception\RouteNotFoundException;
 
 class LocalizedUrlGenerator
 {
@@ -49,6 +50,10 @@ public function generateFromRequest($locale = null, $parameters = null, $absolut
         $locale = $locale ?: $this->detectLocale($urlBuilder);
         $parameters = $this->prepareParameters($locale, $parameters ?: $this->getRouteParameters());
 
+        if ($url = $this->generateFromNamedRoute($locale, $parameters, $absolute)) {
+            return $url . $urlBuilder->getQueryString();
+        }
+
         if ( ! $this->is404()) {
             $urlBuilder->setPath($this->replaceParameters($this->route->uri(), $parameters));
         }
@@ -64,6 +69,67 @@ public function generateFromRequest($locale = null, $parameters = null, $absolut
         return $urlBuilder->build($absolute);
     }
 
+    /**
+     * Generate a URL for a named route.
+     *
+     * @param string $locale
+     * @param array $parameters
+     * @param bool $absolute
+     *
+     * @return string
+     */
+    protected function generateFromNamedRoute($locale, $parameters, $absolute)
+    {
+        if ( ! $this->routeExists()) {
+            return '';
+        }
+
+        $name = $this->route->getName();
+
+        // Localized routes without a name will still have the locale prefix as a name.
+        // Strip the prefix from the name to make sure the route has a base name set.
+        if ($this->stripLocaleFromRouteName($name) === '') {
+            return '';
+        }
+
+        try {
+            return route($name, $parameters, $absolute, $locale);
+        } catch (RouteNotFoundException $e) {
+            return '';
+        }
+    }
+
+    /**
+     * Strip the locale from the beginning of a route name.
+     *
+     * @param string $name
+     *
+     * @return string
+     */
+    protected function stripLocaleFromRouteName($name)
+    {
+        $parts = explode('.', $name);
+
+        // If there is no dot in the route name,
+        // there is no locale in the route name.
+        if (count($parts) === 1) {
+            return $name;
+        }
+
+        $locales = $this->getLocaleKeys();
+
+        // If the first part of the route name is a valid
+        // locale, then remove it from the array.
+        if (in_array($parts[0], $locales)) {
+            array_shift($parts);
+        }
+
+        // Rebuild the normalized route name.
+        $name = join('.', $parts);
+
+        return $name;
+    }
+
     /**
      * Check if the current route is localized.
      *

src/UrlBuilder.php

@@ -121,6 +121,16 @@ public function setSlugs(array $slugs)
         return $this;
     }
 
+    /**
+     * Get the query string.
+     *
+     * @return string
+     */
+    public function getQueryString()
+    {
+        return $this->get('query') ? '?' . $this->get('query') : '';
+    }
+
     /**
      * Get the value of a URL part.
      *

tests/Unit/Macros/LocalizedUrlMacroTest.php

@@ -9,6 +9,7 @@
 use Illuminate\Database\Eloquent\ModelNotFoundException;
 use Illuminate\Support\Facades\App;
 use Illuminate\Support\Facades\Config;
+use Illuminate\Support\Facades\Lang;
 use Illuminate\Support\Facades\Route;
 use Illuminate\Support\Facades\View;
 
@@ -660,6 +661,41 @@ public function it_returns_a_url_with_query_string_for_existing_localized_named_
         ], $response->original);
     }
 
+    /** @test */
+    public function it_returns_a_url_with_translated_slugs_for_named_routes()
+    {
+        $this->setSupportedLocales(['en', 'nl']);
+        $this->setUseLocaleMiddleware(true);
+        $this->setAppLocale('en');
+
+        $this->setTranslations([
+            'nl' => [
+                'my-route' => 'nl-route',
+            ],
+            'en' => [
+                'my-route' => 'en-route',
+            ],
+        ]);
+
+        Route::localized(function () {
+            Route::get(Lang::uri('route/my-route'), function () {
+                return [
+                    'current' => Route::localizedUrl(),
+                    'en' => Route::localizedUrl('en'),
+                    'nl' => Route::localizedUrl('nl'),
+                ];
+            })->name('route');
+        });
+
+        $response = $this->call('GET', '/nl/route/nl-route');
+        $response->assertOk();
+        $this->assertEquals([
+            'current' => url('/nl/route/nl-route'),
+            'en' => url('/en/route/en-route'),
+            'nl' => url('/nl/route/nl-route'),
+        ], $response->original);
+    }
+
     /**
      * Set a custom view path so Laravel will find our custom 440 error view.
      *