Fixed formatting of mbld results

Author: coder13

src/pages/Competition/Round/ConfigureAssignmentsDialog/PersonAssignmentRow.tsx

@@ -3,14 +3,14 @@ import { roundFormatById } from '../../../../lib/domain/events';
 import { acceptedRegistration, isOrganizerOrDelegate } from '../../../../lib/domain/persons';
 import TableAssignmentCell from '../TableAssignmentCell';
 import StaffAssignmentsSummary from './StaffAssignmentsSummary';
+import { formatSeedResult } from './formatSeedResult';
 import type { PersonWithSeedResult, Room } from './types';
 import { EmojiPeople } from '@mui/icons-material';
 import CheckIcon from '@mui/icons-material/Check';
 import { Checkbox, TableCell, TableRow, Tooltip } from '@mui/material';
 import { grey, red, yellow } from '@mui/material/colors';
 import { makeStyles } from '@mui/styles';
 import type { EventId, Person, Round } from '@wca/helpers';
-import { formatCentiseconds } from '@wca/helpers';
 import clsx from 'clsx';
 
 const useStyles = makeStyles(() => ({
@@ -64,8 +64,7 @@ const PersonAssignmentRow = ({
   const rankingResult =
     roundFormat === 'average' ? person.seedResult?.average : person.seedResult?.single;
 
-  const formattedRankingResult =
-    rankingResult && !isNaN(rankingResult) && formatCentiseconds(rankingResult);
+  const formattedRankingResult = formatSeedResult(eventId, roundFormat, rankingResult);
 
   const totalStaffAssignments =
     person?.assignments

src/pages/Competition/Round/ConfigureAssignmentsDialog/formatSeedResult.test.ts

@@ -0,0 +1,29 @@
+import { formatSeedResult } from './formatSeedResult';
+import { encodeMultiResult } from '@wca/helpers';
+import { describe, expect, it } from 'vitest';
+
+describe('formatSeedResult', () => {
+  it('formats multiblind results', () => {
+    const result = encodeMultiResult({ solved: 10, attempted: 12, centiseconds: 6000 });
+
+    expect(formatSeedResult('333mbf', 'single', result)).toBe('10/12 1:00');
+  });
+
+  it('formats multiblind DNF', () => {
+    expect(formatSeedResult('333mbf', 'average', -1)).toBe('DNF');
+  });
+
+  it('formats fewest moves based on ranking type', () => {
+    expect(formatSeedResult('333fm', 'average', 334)).toBe('3.34');
+    expect(formatSeedResult('333fm', 'single', 40)).toBe('40');
+  });
+
+  it('formats standard events in centiseconds', () => {
+    expect(formatSeedResult('333', 'average', 1234)).toBe('12.34');
+  });
+
+  it('returns undefined for empty or invalid results', () => {
+    expect(formatSeedResult('333', 'single', undefined)).toBe('-');
+    expect(formatSeedResult('333', 'single', NaN as number)).toBe('-');
+  });
+});

src/pages/Competition/Round/ConfigureAssignmentsDialog/formatSeedResult.ts

@@ -0,0 +1,39 @@
+import {
+  type AttemptResult,
+  decodeMultiResult,
+  type EventId,
+  formatCentiseconds,
+  formatMultiResult,
+  type RankingType,
+} from '@wca/helpers';
+
+const isValidResult = (result: AttemptResult | null | undefined) =>
+  result !== null && result !== undefined && !Number.isNaN(result as number);
+
+const formatFewestMovesAverage = (result: AttemptResult) => ((result as number) / 100).toFixed(2);
+
+export const formatSeedResult = (
+  eventId: EventId,
+  rankingType: RankingType,
+  result?: AttemptResult
+) => {
+  if (!result) {
+    return '-';
+  }
+
+  if (!isValidResult(result)) {
+    return undefined;
+  }
+
+  if (eventId === '333mbf') {
+    return formatMultiResult(decodeMultiResult(result));
+  }
+
+  if (eventId === '333fm') {
+    return rankingType === 'average'
+      ? formatFewestMovesAverage(result)
+      : (result as number).toString();
+  }
+
+  return formatCentiseconds(result as number);
+};