Fix scorecard CSV export for unknown round formats

Author: coder13

src/lib/domain/events.test.ts

@@ -1,4 +1,10 @@
-import { eventNameById, shortEventNameById, roundFormatById, sortWcifEvents } from './events';
+import {
+  eventNameById,
+  shortEventNameById,
+  roundFormatById,
+  roundFormatShortById,
+  sortWcifEvents,
+} from './events';
 import { type Event } from '@wca/helpers';
 import { describe, it, expect } from 'vitest';
 
@@ -96,6 +102,20 @@ describe('roundFormatById', () => {
   });
 });
 
+describe('roundFormatShortById', () => {
+  it('returns short code for known format IDs', () => {
+    expect(roundFormatShortById('a')).toBe('ao5');
+  });
+
+  it('falls back to raw format ID for unknown formats', () => {
+    expect(roundFormatShortById('5')).toBe('5');
+  });
+
+  it('returns empty string for undefined format', () => {
+    expect(roundFormatShortById(undefined)).toBe('');
+  });
+});
+
 describe('sortWcifEvents', () => {
   it('sorts events in canonical order', () => {
     const wcifEvents: Event[] = [

src/lib/domain/events.ts

@@ -59,3 +59,8 @@ const roundFormats: RoundFormat[] = [
 
 export const roundFormatById = (id: string | undefined): RoundFormat | undefined =>
   id ? roundFormats.find((roundFormat) => roundFormat.id === id) : undefined;
+
+export const roundFormatShortById = (id: string | undefined): string => {
+  const roundFormat = roundFormatById(id);
+  return roundFormat ? roundFormat.short : id ?? '';
+};

src/pages/Competition/Export/index.tsx

@@ -1,5 +1,5 @@
 import { findGroupActivitiesByRound, parseActivityCode } from '../../../lib/domain/activities';
-import { eventNameById, roundFormatById } from '../../../lib/domain/events';
+import { eventNameById, roundFormatShortById } from '../../../lib/domain/events';
 import { acceptedRegistrations } from '../../../lib/domain/persons';
 import { type ActivityWithParent } from '../../../lib/domain/types';
 import {
@@ -255,7 +255,7 @@ const ExportPage = () => {
           cutoff_time: round.cutoff
             ? `1 or 2 < ${formatCentiseconds(round.cutoff.attemptResult)}`
             : '',
-          round_format: roundFormatById(round.format)?.short ?? '',
+          round_format: roundFormatShortById(round.format),
           advancement_condition: round.advancementCondition
             ? advancementConditionToText(round.advancementCondition)
             : '',