Fix logout to clear credentials and add switch deployment command (#760)

- Logout now clears stored credentials via secretsManager.clearAllAuthData()
- Add "Switch Deployment" command to change deployments without clearing credentials

Author: EhabY

package.json

@@ -217,6 +217,12 @@
 				"category": "Coder",
 				"icon": "$(sign-out)"
 			},
+			{
+				"command": "coder.switchDeployment",
+				"title": "Switch Deployment",
+				"category": "Coder",
+				"icon": "$(arrow-swap)"
+			},
 			{
 				"command": "coder.open",
 				"title": "Open Workspace",
@@ -297,6 +303,10 @@
 					"command": "coder.logout",
 					"when": "coder.authenticated"
 				},
+				{
+					"command": "coder.switchDeployment",
+					"when": "coder.authenticated"
+				},
 				{
 					"command": "coder.createWorkspace",
 					"when": "coder.authenticated"
@@ -351,6 +361,10 @@
 					"command": "coder.logout",
 					"when": "coder.authenticated && view == myWorkspaces"
 				},
+				{
+					"command": "coder.switchDeployment",
+					"when": "coder.authenticated && view == myWorkspaces"
+				},
 				{
 					"command": "coder.login",
 					"when": "!coder.authenticated && view == myWorkspaces"

src/commands.ts

@@ -74,9 +74,8 @@ export class Commands {
 	}
 
 	/**
-	 * Log into the provided deployment. If the deployment URL is not specified,
-	 * ask for it first with a menu showing recent URLs along with the default URL
-	 * and CODER_URL, if those are set.
+	 * Log into a deployment. If already authenticated, this is a no-op.
+	 * If no URL is provided, shows a menu of recent URLs plus defaults.
 	 */
 	public async login(args?: {
 		url?: string;
@@ -85,6 +84,13 @@ export class Commands {
 		if (this.deploymentManager.isAuthenticated()) {
 			return;
 		}
+		await this.performLogin(args);
+	}
+
+	private async performLogin(args?: {
+		url?: string;
+		autoLogin?: boolean;
+	}): Promise<void> {
 		this.logger.debug("Logging in");
 
 		const currentDeployment = await this.secretsManager.getCurrentDeployment();
@@ -197,7 +203,7 @@ export class Commands {
 	}
 
 	/**
-	 * Log out from the currently logged-in deployment.
+	 * Log out and clear stored credentials, requiring re-authentication on next login.
 	 */
 	public async logout(): Promise<void> {
 		if (!this.deploymentManager.isAuthenticated()) {
@@ -206,8 +212,15 @@ export class Commands {
 
 		this.logger.debug("Logging out");
 
+		const safeHostname =
+			this.deploymentManager.getCurrentDeployment()?.safeHostname;
+
 		await this.deploymentManager.clearDeployment();
 
+		if (safeHostname) {
+			await this.secretsManager.clearAllAuthData(safeHostname);
+		}
+
 		vscode.window
 			.showInformationMessage("You've been logged out of Coder!", "Login")
 			.then((action) => {
@@ -221,6 +234,15 @@ export class Commands {
 		this.logger.debug("Logout complete");
 	}
 
+	/**
+	 * Switch to a different deployment without clearing credentials.
+	 * If login fails or user cancels, stays on current deployment.
+	 */
+	public async switchDeployment(): Promise<void> {
+		this.logger.debug("Switching deployment");
+		await this.performLogin();
+	}
+
 	/**
 	 * Create a new workspace for the currently logged-in deployment.
 	 *

src/extension.ts

@@ -197,6 +197,10 @@ export async function activate(ctx: vscode.ExtensionContext): Promise<void> {
 			"coder.logout",
 			commands.logout.bind(commands),
 		),
+		vscode.commands.registerCommand(
+			"coder.switchDeployment",
+			commands.switchDeployment.bind(commands),
+		),
 		vscode.commands.registerCommand("coder.open", commands.open.bind(commands)),
 		vscode.commands.registerCommand(
 			"coder.openDevContainer",