Fix accessing manifest behind basic auth

code-asher · code-asher · commit e5fc63f2c8fa · 2019-12-09T11:25:59.000-06:00
Apparently the manifest spec doesn't include sending credentials in an attempt to be secure by default. Fixes #1212.
diff --git a/src/browser/workbench-build.html b/src/browser/workbench-build.html
@@ -37,7 +37,7 @@
 
 		<!-- Workbench Icon/Manifest/CSS -->
 		<link rel="icon" href="./favicon.ico" type="image/x-icon" />
-		<link rel="manifest" href="./manifest.json">
+		<link rel="manifest" href="./manifest.json" crossorigin="use-credentials">
 		<link rel="apple-touch-icon" href="./static-{{COMMIT}}/out/vs/server/src/media/code-server.png" />
 		<link data-name="vs/workbench/workbench.web.api" rel="stylesheet" href="./static-{{COMMIT}}/out/vs/workbench/workbench.web.api.css">
 		<meta name="apple-mobile-web-app-capable" content="yes">
diff --git a/src/browser/workbench.html b/src/browser/workbench.html
@@ -37,7 +37,7 @@
 
 		<!-- Workbench Icon/Manifest/CSS -->
 		<link rel="icon" href="./favicon.ico" type="image/x-icon" />
-		<link rel="manifest" href="./manifest.json">
+		<link rel="manifest" href="./manifest.json" crossorigin="use-credentials">
 	</head>
 
 	<body aria-label="">
