Implement getconfigsettings admin endpoint

Author: Piotr Slupski

filecloudapi/datastructures.py

@@ -328,7 +328,7 @@ def _set_entries(self, response: Element):
             if elem.tag != "setting":
                 continue
 
-            self.entries[elem.get("param")] = elem.get("value")
+            self.entries[list(elem)[0].text] = list(elem)[1].text
 
 
 @dataclass

filecloudapi/fcserver.py

@@ -8,7 +8,7 @@
 import xml.etree.ElementTree as ET
 from io import SEEK_CUR, SEEK_END, SEEK_SET, BufferedReader, BytesIO
 from pathlib import Path
-from typing import Dict, Optional, Union
+from typing import Dict, Optional, Union, List
 from urllib.parse import urlencode
 
 import requests
@@ -1661,7 +1661,7 @@ def admin_resetpolicyforuser(self, username: str) -> None:
 
         self._raise_exception_from_command(resp)
 
-    def get_config_settings(self, config: list[str]) -> None:
+    def admin_get_config_settings(self, config: List[str]) -> ServerSettings:
         """
         Retrieve Filecloud configuration settings. The config list should
         contain FC configuration keys.
@@ -1673,18 +1673,14 @@ def get_config_settings(self, config: list[str]) -> None:
         except (ValueError, TypeError):
             count = 0
 
-        config_opts = []
+        config_opts = {}
         for i in range(count):
             param_key = f"param{i}"
-            config_opts[param_key] = config[i]
+            config_opts[param_key] = config[i]  # type:ignore
 
-        resp = self._api_call(
-            "/admin/getconfigsetting",
-            {
-                "count": str(len(config_opts)),
-                **{f"param{i}": value for i, value in enumerate(config_opts)},
-            },
-        )
+        config_opts["count"] = str(len(config_opts))
+
+        resp = self._api_call("/admin/getconfigsetting", config_opts)
 
         settings = ServerSettings(resp)
         return settings

pyproject.toml

@@ -1,7 +1,7 @@
 [tool.poetry]
 
 name = "filecloudapi-python"
-version = "0.4.1"
+version = "0.4.2"
 description = "A Python library to connect to a Filecloud server"
 
 packages = [{ include = "filecloudapi" }]