From f815fd448f7f7c9b2119a870e68bb2667f9d2253 Mon Sep 17 00:00:00 2001 From: Adi Prasetyo Date: Tue, 10 Mar 2026 10:19:19 +0700 Subject: [PATCH 1/2] refactor: fix phpstan no type specified SaveModelTest --- tests/system/Models/SaveModelTest.php | 2 +- utils/phpstan-baseline/loader.neon | 2 +- utils/phpstan-baseline/missingType.property.neon | 7 +------ 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/tests/system/Models/SaveModelTest.php b/tests/system/Models/SaveModelTest.php index b2bdaa2a4103..ada29df615ef 100644 --- a/tests/system/Models/SaveModelTest.php +++ b/tests/system/Models/SaveModelTest.php @@ -291,7 +291,7 @@ public function testSaveNewEntityWithDate(): void protected $returnType = 'object'; protected $useSoftDeletes = true; protected $dateFormat = 'date'; - public $name = ''; + public string $name = ''; }; $entity->name = 'Mark'; diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon index 65057bd0736b..c065fa299fd3 100644 --- a/utils/phpstan-baseline/loader.neon +++ b/utils/phpstan-baseline/loader.neon @@ -1,4 +1,4 @@ -# total 2063 errors +# total 2062 errors includes: - argument.type.neon diff --git a/utils/phpstan-baseline/missingType.property.neon b/utils/phpstan-baseline/missingType.property.neon index 2dce190bf003..451773e8bc5d 100644 --- a/utils/phpstan-baseline/missingType.property.neon +++ b/utils/phpstan-baseline/missingType.property.neon @@ -1,4 +1,4 @@ -# total 48 errors +# total 47 errors parameters: ignoreErrors: @@ -236,8 +236,3 @@ parameters: message: '#^Property CodeIgniter\\Database\\Live\\MySQLi\\NumberNativeTest\:\:\$tests has no type specified\.$#' count: 1 path: ../../tests/system/Database/Live/MySQLi/NumberNativeTest.php - - - - message: '#^Property CodeIgniter\\Model@anonymous/tests/system/Models/SaveModelTest\.php\:286\:\:\$name has no type specified\.$#' - count: 1 - path: ../../tests/system/Models/SaveModelTest.php From 6a133f4a98c626543b670514256abffa49cfe6c7 Mon Sep 17 00:00:00 2001 From: Adi Prasetyo Date: Tue, 10 Mar 2026 12:26:59 +0700 Subject: [PATCH 2/2] remove unused properties --- tests/system/Models/SaveModelTest.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/system/Models/SaveModelTest.php b/tests/system/Models/SaveModelTest.php index ada29df615ef..be77d958ff7f 100644 --- a/tests/system/Models/SaveModelTest.php +++ b/tests/system/Models/SaveModelTest.php @@ -291,7 +291,6 @@ public function testSaveNewEntityWithDate(): void protected $returnType = 'object'; protected $useSoftDeletes = true; protected $dateFormat = 'date'; - public string $name = ''; }; $entity->name = 'Mark'; @@ -370,7 +369,6 @@ public function testUseAutoIncrementSetToFalseSaveObject(): void public function testSaveNewEntityWithMappedPrimaryKey(): void { $entity = new class () extends Entity { - protected string $name; protected $attributes = [ 'id' => null, 'name' => null,