refactor(http): address feedbacks

Author: memleakd

system/HTTP/IncomingRequest.php

@@ -123,6 +123,11 @@ class IncomingRequest extends Request
      */
     protected $userAgent;
 
+    /**
+     * Typed input data selector.
+     */
+    protected ?RequestInput $input = null;
+
     /**
      * Constructor
      *
@@ -169,6 +174,11 @@ public function __construct($config, ?URI $uri = null, $body = 'php://input', ?U
         $this->detectLocale($config);
     }
 
+    public function __clone()
+    {
+        $this->input = null;
+    }
+
     private function getPostMaxSize(): int
     {
         $postMaxSize = ini_get('post_max_size');
@@ -574,7 +584,7 @@ public function getGet($index = null, $filter = null, $flags = null)
      */
     public function input(): RequestInput
     {
-        return new RequestInput($this, service('inputdatafactory'));
+        return $this->input ??= new RequestInput($this, service('inputdatafactory'));
     }
 
     /**

tests/system/HTTP/RequestInputTest.php

@@ -56,6 +56,23 @@ public function testInputReturnsRequestInput(): void
         $this->assertInstanceOf(RequestInput::class, $input);
     }
 
+    public function testInputReturnsSameRequestInputInstance(): void
+    {
+        $request = $this->createRequest();
+
+        $this->assertSame($request->input(), $request->input());
+    }
+
+    public function testClonedRequestGetsNewRequestInputInstance(): void
+    {
+        $request = $this->createRequest();
+        $input   = $request->input();
+
+        $clonedRequest = $request->withMethod(Method::POST);
+
+        $this->assertNotSame($input, $clonedRequest->input());
+    }
+
     public function testGetReadsGetData(): void
     {
         service('superglobals')->setGet('page', '3');

user_guide_src/source/incoming/incomingrequest.rst

@@ -251,6 +251,7 @@ Filtering a POST variable would look like this:
 
 All of the methods mentioned above support the filter type passed in as the second parameter, with the
 exception of ``getJSON()`` and ``getRawInput()``.
+The typed input helpers returned by ``input()`` do not accept filter parameters.
 
 Retrieving Headers
 ******************