refactor: remove deprecations in Services

Author: paulbalandan

system/Config/BaseService.php

@@ -175,15 +175,6 @@ class BaseService
      */
     protected static $discovered = false;
 
-    /**
-     * A cache of other service classes we've found.
-     *
-     * @var array
-     *
-     * @deprecated 4.5.0 No longer used.
-     */
-    protected static $services = [];
-
     /**
      * A cache of the names of services classes found.
      *

system/Config/Services.php

@@ -517,17 +517,10 @@ public static function renderer(?string $viewPath = null, ?ViewConfig $config =
      * createRequest() injects IncomingRequest or CLIRequest.
      *
      * @return CLIRequest|IncomingRequest
-     *
-     * @deprecated The parameter $config and $getShared are deprecated.
      */
-    public static function request(?App $config = null, bool $getShared = true)
+    public static function request()
     {
-        if ($getShared) {
-            return static::getSharedInstance('request', $config);
-        }
-
-        // @TODO remove the following code for backward compatibility
-        return AppServices::incomingrequest($config, $getShared);
+        return static::getSharedInstance('request');
     }
 
     /**

user_guide_src/source/changelogs/v4.8.0.rst

@@ -43,6 +43,7 @@ Method Signature Changes
        - The updated method signature is now ``handleRequest(?RouteCollectionInterface $routes, ?Cache $cacheConfig = null)``.
     - ``CodeIgniter\CodeIgniter::gatherOutput()`` no longer accepts the deprecated ``$cacheConfig`` parameter.
        As this is the first parameter, custom uses of this method will need to be updated to remove the parameter.
+- **Config:** ``CodeIgniter\Config\Services::request()`` no longer accepts any parameter.
 
 Removed Deprecated Items
 ========================
@@ -70,6 +71,8 @@ Removed Deprecated Items
     - ``CodeIgniter\CodeIgniter::determinePath()``
     - ``CodeIgniter\CodeIgniter::callExit()``
     - ``CodeIgniter\Test\MockCodeIgniter::callExit()``
+- **Config:** Removed the following property deprecated:
+    - ``CodeIgniter\Config\BaseService::$services`` (deprecated since v4.5.0)
 - **Debug:** Removed the following properties and methods deprecated since v4.4.0:
     - ``CodeIgniter\Debug\Exceptions::$ob_level``
     - ``CodeIgniter\Debug\Exceptions::$viewPath``