fix phpstan

Author: michalsn

system/BaseModel.php

@@ -18,6 +18,7 @@
 use CodeIgniter\Database\BaseResult;
 use CodeIgniter\Database\Exceptions\DatabaseException;
 use CodeIgniter\Database\Exceptions\DataException;
+use CodeIgniter\Database\Exceptions\UniqueConstraintViolationException;
 use CodeIgniter\Database\Query;
 use CodeIgniter\Database\RawSql;
 use CodeIgniter\DataCaster\Cast\CastInterface;
@@ -869,6 +870,7 @@ protected function validateID(mixed $id, bool $allowArray = true): void
      * @return ($returnID is true ? false|int|string : bool)
      *
      * @throws ReflectionException
+     * @throws UniqueConstraintViolationException
      */
     public function insert($row = null, bool $returnID = true)
     {

system/Model.php

@@ -723,6 +723,8 @@ protected function doProtectFieldsForInsert(array $row): array
      *
      * @param array<string, mixed>|object $attributes
      * @param array<string, mixed>|object $values
+     *
+     * @return array<string, mixed>|false|object
      */
     public function firstOrInsert(array|object $attributes, array|object $values = []): array|false|object
     {

tests/system/Models/FirstOrInsertModelTest.php

@@ -39,7 +39,7 @@ public function testReturnsExistingRecord(): void
 
         $row = $this->model->firstOrInsert(['email' => 'derek@world.com']);
 
-        $this->assertNotNull($row);
+        $this->assertIsObject($row);
         $this->assertSame('Derek Jones', $row->name);
         $this->assertSame('derek@world.com', $row->email);
         $this->assertSame('US', $row->country);
@@ -66,7 +66,7 @@ public function testValuesAreIgnoredWhenRecordExists(): void
             ['name' => 'Should Not Change', 'country' => 'XX'],
         );
 
-        $this->assertNotFalse($row);
+        $this->assertIsObject($row);
         $this->assertSame('Derek Jones', $row->name);
         $this->assertSame('US', $row->country);
     }
@@ -81,7 +81,7 @@ public function testInsertsNewRecordWhenNotFound(): void
             'country' => 'US',
         ]);
 
-        $this->assertNotFalse($row);
+        $this->assertIsObject($row);
         $this->assertSame('new@example.com', $row->email);
         $this->seeInDatabase('user', ['email' => 'new@example.com', 'deleted_at' => null]);
     }
@@ -95,7 +95,7 @@ public function testMergesValuesOnInsert(): void
             ['name' => 'New User', 'country' => 'CA'],
         );
 
-        $this->assertNotFalse($row);
+        $this->assertIsObject($row);
         $this->assertSame('New User', $row->name);
         $this->assertSame('CA', $row->country);
         $this->seeInDatabase('user', [
@@ -119,7 +119,7 @@ public function testAcceptsObjectForValues(): void
             $values,
         );
 
-        $this->assertNotFalse($row);
+        $this->assertIsObject($row);
         $this->assertSame('Object User', $row->name);
         $this->assertSame('DE', $row->country);
         $this->seeInDatabase('user', ['email' => 'object@example.com', 'deleted_at' => null]);
@@ -134,7 +134,7 @@ public function testAcceptsObjectForAttributes(): void
 
         $row = $this->model->firstOrInsert($attributes);
 
-        $this->assertNotFalse($row);
+        $this->assertIsObject($row);
         $this->assertSame('Derek Jones', $row->name);
         $this->seeNumRecords(4, 'user', ['deleted_at' => null]);
     }
@@ -150,7 +150,7 @@ public function testAcceptsObjectForAttributesAndInsertsWhenNotFound(): void
 
         $row = $this->model->firstOrInsert($attributes);
 
-        $this->assertNotNull($row);
+        $this->assertIsObject($row);
         $this->assertSame('new@example.com', $row->email);
         $this->seeInDatabase('user', ['email' => 'new@example.com', 'deleted_at' => null]);
     }
@@ -183,7 +183,7 @@ protected function doInsert(array $row): bool
             ['name' => 'Race User', 'country' => 'US'],
         );
 
-        $this->assertNotFalse($row);
+        $this->assertIsObject($row);
         $this->assertSame('race@example.com', $row->email);
         // The "other process" inserted exactly one record.
         $this->seeNumRecords(1, 'user', ['email' => 'race@example.com', 'deleted_at' => null]);
@@ -218,7 +218,7 @@ protected function doInsert(array $row): bool
             ['name' => 'Race User', 'country' => 'US'],
         );
 
-        $this->assertNotFalse($row);
+        $this->assertIsObject($row);
         $this->assertSame('race@example.com', $row->email);
         $this->seeNumRecords(1, 'user', ['email' => 'race@example.com', 'deleted_at' => null]);
     }