Skip to content

Commit 2af7367

Browse files
fix: Do not create namespace during helm install
1 parent ab70aa0 commit 2af7367

2 files changed

Lines changed: 4 additions & 8 deletions

File tree

functions/helm.ps1

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<#PSScriptInfo
2-
.VERSION 1.3.0
2+
.VERSION 1.3.1
33
.GUID 04273f72-e001-415b-add0-e5e95e378355
44
.AUTHOR Code Dx
55
.DESCRIPTION Includes Helm-related helpers
@@ -76,11 +76,7 @@ function Invoke-HelmCommand([string] $message,
7676
}
7777

7878
if (-not $dryRun) {
79-
if (Test-Namespace $namespace) {
80-
Wait-AllRunningPods "Pre-Helm Install: $message" $waitSeconds $namespace
81-
} else {
82-
Write-Verbose "Skipping pre-helm install check because namespace '$namespace' does not exist or insufficient privileges affected the namespace test."
83-
}
79+
Wait-AllRunningPods "Pre-Helm Install: $message" $waitSeconds $namespace
8480
}
8581

8682
# NOTE: Latter values files take precedence over former ones
@@ -116,7 +112,7 @@ function Invoke-HelmCommand([string] $message,
116112
}
117113

118114
$crdAction = $skipCRDs ? '--skip-crds' : ''
119-
$helmOutput = helm upgrade --namespace $namespace --install --create-namespace $valuesParam $releaseName --timeout $timeout @values $chartReference @versionParam $crdAction $dryRunParam $debugParam
115+
$helmOutput = helm upgrade --namespace $namespace --install $valuesParam $releaseName --timeout $timeout @values $chartReference @versionParam $crdAction $dryRunParam $debugParam
120116
if ($LASTEXITCODE -ne 0) {
121117
throw "Unable to run helm upgrade/install, helm exited with code $LASTEXITCODE."
122118
}

guided-setup.psd1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
RootModule = 'guided-setup'
1313

1414
# Version number of this module.
15-
ModuleVersion = '1.12.0'
15+
ModuleVersion = '1.13.0'
1616

1717
# Supported PSEditions
1818
CompatiblePSEditions = @('Core')

0 commit comments

Comments
 (0)